All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Hao Xu <haoxu@linux.alibaba.com>,
	Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring <io-uring@vger.kernel.org>
Subject: Re: Question about poll_multi_file
Date: Thu, 3 Jun 2021 12:01:04 -0600	[thread overview]
Message-ID: <f2fa9534-e07c-fd18-759e-b3ca99b714a7@kernel.dk> (raw)
In-Reply-To: <e90a3bdd-d60c-9b82-e711-c7a0b4f32c09@linux.alibaba.com>

On 6/3/21 6:53 AM, Hao Xu wrote:
> Hi Jens,
> I've a question about poll_multi_file in io_do_iopoll().
> It keeps spinning in f_op->iopoll() if poll_multi_file is
> true (and we're under the requested amount). But in my
> understanding, reqs may be in different hardware queues
> for blk-mq device even in this situation.
> Should we consider the hardware queue number as well? Some
> thing like below:

That looks reasonable to me - do you have any performance
numbers to go with it?

-- 
Jens Axboe


  reply	other threads:[~2021-06-03 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 12:53 Question about poll_multi_file Hao Xu
2021-06-03 18:01 ` Jens Axboe [this message]
2021-06-06 14:08   ` Hao Xu
2021-06-07 16:45     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2fa9534-e07c-fd18-759e-b3ca99b714a7@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=haoxu@linux.alibaba.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.