From: cuigaosheng <cuigaosheng1@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <dinguyen@kernel.org>, <richard.gong@intel.com>,
<atull@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe()
Date: Mon, 14 Nov 2022 19:11:16 +0800 [thread overview]
Message-ID: <4cb8207d-e2c1-b459-e456-d8998f8180c8@huawei.com> (raw)
In-Reply-To: <Y3HtGbqAvb15Sa9a@kroah.com>
> How was this found and tested?
Thanks for taking time to review this patch.
I found this through the cocci script, I made the patch based on the code logic,
but I have not tested it due to the lack of hardware devices.
On 2022/11/14 15:24, Greg KH wrote:
> On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote:
>> The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
>> IS_ERR() to check the return value, and return it on failure.
> How was this found and tested?
>
> thanks,
>
> greg k-h
> .
next prev parent reply other threads:[~2022-11-14 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 2:59 [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe() Gaosheng Cui
2022-11-14 7:24 ` Greg KH
2022-11-14 11:11 ` cuigaosheng [this message]
2022-11-14 11:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cb8207d-e2c1-b459-e456-d8998f8180c8@huawei.com \
--to=cuigaosheng1@huawei.com \
--cc=atull@kernel.org \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.gong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.