All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: dinguyen@kernel.org, richard.gong@intel.com, atull@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe()
Date: Mon, 14 Nov 2022 08:24:09 +0100	[thread overview]
Message-ID: <Y3HtGbqAvb15Sa9a@kroah.com> (raw)
In-Reply-To: <20221114025921.1194834-1-cuigaosheng1@huawei.com>

On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote:
> The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
> IS_ERR() to check the return value, and return it on failure.

How was this found and tested?

thanks,

greg k-h

  reply	other threads:[~2022-11-14  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  2:59 [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe() Gaosheng Cui
2022-11-14  7:24 ` Greg KH [this message]
2022-11-14 11:11   ` cuigaosheng
2022-11-14 11:33     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3HtGbqAvb15Sa9a@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=atull@kernel.org \
    --cc=cuigaosheng1@huawei.com \
    --cc=dinguyen@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard.gong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.