[PATCH 3/4] Add lightmediascanner_git recipe

[PATCH 3/4] Add lightmediascanner_git recipe

[fidencio]

From: Eduardo Lima (Etrunko) <eblima@gmail.com>

Signed-off-by: Eduardo Lima (Etrunko) <eblima@gmail.com>
---
 recipes/lightmediascanner/lightmediascanner_git.bb |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 recipes/lightmediascanner/lightmediascanner_git.bb

diff --git a/recipes/lightmediascanner/lightmediascanner_git.bb b/recipes/lightmediascanner/lightmediascanner_git.bb
new file mode 100644
index 0000000..751d384
--- /dev/null
+++ b/recipes/lightmediascanner/lightmediascanner_git.bb
@@ -0,0 +1,7 @@
+require lightmediascanner.inc
+
+SRCREV = "${AUTOREV}"
+PV = "0.4.0+git_${SRCREV}"
+
+SRC_URI = "git://git.profusion.mobi/users/etrunko/lightmediascanner.git;protocol=git;branch=master"
+S = "${WORKDIR}/git"
-- 
1.7.3.1

Re: [PATCH 3/4] Add lightmediascanner_git recipe

[Stefan Schmidt]

On Fri, 2010-10-22 at 22:14, fidencio@profusion.mobi wrote:
> From: Eduardo Lima (Etrunko) <eblima@gmail.com>
> 
> Signed-off-by: Eduardo Lima (Etrunko) <eblima@gmail.com>
> ---
>  recipes/lightmediascanner/lightmediascanner_git.bb |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/lightmediascanner/lightmediascanner_git.bb
> 
> diff --git a/recipes/lightmediascanner/lightmediascanner_git.bb b/recipes/lightmediascanner/lightmediascanner_git.bb
> new file mode 100644
> index 0000000..751d384
> --- /dev/null
> +++ b/recipes/lightmediascanner/lightmediascanner_git.bb
> @@ -0,0 +1,7 @@
> +require lightmediascanner.inc
> +
> +SRCREV = "${AUTOREV}"

Please don't do this. The _git recipes we use in OE have a rev specified instead
of building HEAD everytime the are called. Specify a sane srcrev here and switch
autorev on in your local.conf if you need it.

Besides this the patch has my ACK and I would apply an updated version.

regards
Stefan Schmidt