From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH 5/6] x86/xstate: address MISRA C:2012 Rule 5.3
Date: Mon, 07 Aug 2023 11:20:21 +0200 [thread overview]
Message-ID: <4ce6f80a5749dff1aee4ba7458f1139d@bugseng.com> (raw)
In-Reply-To: <82438990-cb32-a2fc-273f-151818834c4d@suse.com>
On 07/08/2023 10:23, Jan Beulich wrote:
> On 04.08.2023 17:27, Nicola Vetrini wrote:
>> Rename the local variables to avoid clashing with function 'xstate'
>> defined below, but declared in the corresponding header file.
>
> Hmm, there are two functions with such a local variable, but you don't
> change those. You change "xsave" instead. The new name you use you took
> from older functions afaict; newer ones use "xstate" (and use of this
> name is extended in pending patches), so preferably we would follow
> that naming model (and eventually rename all "xsave_area" as well).
>
> Also - does "below" really matter and hence warrant the "but"?
>
> Jan
I made a typo in the commit message. Indeed 'xsave' here is the culprit.
I think 'xstate'
is ok for a rename, as it does not shadow anything afaict.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
next prev parent reply other threads:[~2023-08-07 9:20 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 15:27 [XEN PATCH 0/6] xen: address MISRA C:2012 Rule 5.3 Nicola Vetrini
2023-08-04 15:27 ` [XEN PATCH 1/6] x86: rename variable 'e820' to " Nicola Vetrini
2023-08-04 21:19 ` Stefano Stabellini
2023-08-07 7:14 ` Nicola Vetrini
2023-08-07 8:09 ` Jan Beulich
2023-08-07 8:59 ` Nicola Vetrini
2023-08-07 9:10 ` Jan Beulich
2023-08-07 11:12 ` Nicola Vetrini
2023-08-07 12:02 ` Jan Beulich
2023-08-08 7:08 ` Nicola Vetrini
2023-08-08 7:21 ` Jan Beulich
2023-08-08 21:21 ` Stefano Stabellini
2023-08-08 21:24 ` Stefano Stabellini
2023-08-07 15:03 ` Nicola Vetrini
2023-08-07 15:07 ` Jan Beulich
2023-08-07 18:39 ` Stefano Stabellini
2023-08-04 15:27 ` [XEN PATCH 2/6] libelf: " Nicola Vetrini
2023-08-04 21:21 ` Stefano Stabellini
2023-08-07 8:11 ` Jan Beulich
2023-08-07 9:03 ` Nicola Vetrini
2023-08-04 15:27 ` [XEN PATCH 3/6] xen/delay: " Nicola Vetrini
2023-08-04 21:23 ` Stefano Stabellini
2023-08-07 8:14 ` Jan Beulich
2023-08-07 9:01 ` Julien Grall
2023-08-07 9:15 ` Jan Beulich
2023-08-07 9:23 ` Nicola Vetrini
2023-08-07 9:32 ` Jan Beulich
2023-08-07 9:33 ` Julien Grall
2023-08-04 15:27 ` [XEN PATCH 4/6] x86/include: " Nicola Vetrini
2023-08-04 21:24 ` Stefano Stabellini
2023-08-07 7:16 ` Nicola Vetrini
2023-08-04 15:27 ` [XEN PATCH 5/6] x86/xstate: " Nicola Vetrini
2023-08-04 21:26 ` Stefano Stabellini
2023-08-07 8:23 ` Jan Beulich
2023-08-07 9:20 ` Nicola Vetrini [this message]
2023-08-04 15:27 ` [XEN PATCH 6/6] x86: refactor macros in 'xen-mca.h' to " Nicola Vetrini
2023-08-04 15:38 ` Nicola Vetrini
2023-08-04 21:30 ` Stefano Stabellini
2023-08-07 8:31 ` Jan Beulich
2023-08-07 10:01 ` Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ce6f80a5749dff1aee4ba7458f1139d@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=consulting@bugseng.com \
--cc=jbeulich@suse.com \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.