All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, tboot-devel@lists.sourceforge.net,
	ning.sun@intel.com, iommu@lists.linux-foundation.org,
	mingo@redhat.com, bp@alien8.de, tglx@linutronix.de,
	dwmw2@infradead.org
Subject: Re: [PATCH v2] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot system
Date: Tue, 10 Nov 2020 16:53:33 +0100	[thread overview]
Message-ID: <4cfa1f1827e0ccbfbc94de3beba64a4a141b2248.camel@linux.intel.com> (raw)
In-Reply-To: <20201110071908.3133-1-zhenzhong.duan@gmail.com>

Hi Zhenzhong

On Tue, 2020-11-10 at 15:19 +0800, Zhenzhong Duan wrote:
> "intel_iommu=off" command line is used to disable iommu but iommu is force
> enabled in a tboot system for security reason.
> 
> However for better performance on high speed network device, a new option
> "intel_iommu=tboot_noforce" is introduced to disable the force on.
> 
> By default kernel should panic if iommu init fail in tboot for security
> reason, but it's unnecessory if we use "intel_iommu=tboot_noforce,off".
> 
> Fix the code setting force_on and move intel_iommu_tboot_noforce
> from tboot code to intel iommu code.
> 
> Fixes: 7304e8f28bb2 ("iommu/vt-d: Correctly disable Intel IOMMU force on")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> ---
> v2: move ckeck of intel_iommu_tboot_noforce into iommu code per Baolu.

I have check it on my TXT testing environment with latest TBOOT,
everything works as expected.

Thanks,
Lukasz

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>, linux-kernel@vger.kernel.org
Cc: ning.sun@intel.com, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, x86@kernel.org, dwmw2@infradead.org,
	baolu.lu@linux.intel.com, joro@8bytes.org,
	iommu@lists.linux-foundation.org,
	tboot-devel@lists.sourceforge.net
Subject: Re: [PATCH v2] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot system
Date: Tue, 10 Nov 2020 16:53:33 +0100	[thread overview]
Message-ID: <4cfa1f1827e0ccbfbc94de3beba64a4a141b2248.camel@linux.intel.com> (raw)
In-Reply-To: <20201110071908.3133-1-zhenzhong.duan@gmail.com>

Hi Zhenzhong

On Tue, 2020-11-10 at 15:19 +0800, Zhenzhong Duan wrote:
> "intel_iommu=off" command line is used to disable iommu but iommu is force
> enabled in a tboot system for security reason.
> 
> However for better performance on high speed network device, a new option
> "intel_iommu=tboot_noforce" is introduced to disable the force on.
> 
> By default kernel should panic if iommu init fail in tboot for security
> reason, but it's unnecessory if we use "intel_iommu=tboot_noforce,off".
> 
> Fix the code setting force_on and move intel_iommu_tboot_noforce
> from tboot code to intel iommu code.
> 
> Fixes: 7304e8f28bb2 ("iommu/vt-d: Correctly disable Intel IOMMU force on")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> ---
> v2: move ckeck of intel_iommu_tboot_noforce into iommu code per Baolu.

I have check it on my TXT testing environment with latest TBOOT,
everything works as expected.

Thanks,
Lukasz


  reply	other threads:[~2020-11-10 17:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  7:19 [PATCH v2] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot system Zhenzhong Duan
2020-11-10  7:19 ` Zhenzhong Duan
2020-11-10 15:53 ` Lukasz Hawrylko [this message]
2020-11-10 15:53   ` Lukasz Hawrylko
2020-11-11  0:24   ` Zhenzhong Duan
2020-11-11  0:24     ` Zhenzhong Duan
2020-11-11  2:17 ` Lu Baolu
2020-11-11  2:17   ` Lu Baolu
2020-11-12  8:13 ` Lukasz Hawrylko
2020-11-12  8:13   ` Lukasz Hawrylko
2020-11-17 23:32 ` Lu Baolu
2020-11-17 23:32   ` Lu Baolu
2020-11-18 13:28   ` Will Deacon
2020-11-18 13:28     ` Will Deacon
2020-11-18 14:19 ` Will Deacon
2020-11-18 14:19   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cfa1f1827e0ccbfbc94de3beba64a4a141b2248.camel@linux.intel.com \
    --to=lukasz.hawrylko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ning.sun@intel.com \
    --cc=tboot-devel@lists.sourceforge.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=zhenzhong.duan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.