From: Chao Yu <chao@kernel.org>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: chao@kernel.org, Wenjie Qi <qiwenjie@xiaomi.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v1 07/12] f2fs: cache: use node cache
Date: Mon, 24 Aug 2026 15:13:45 +0800 [thread overview]
Message-ID: <4d408110-0579-4916-9e28-e3e831486980@kernel.org> (raw)
In-Reply-To: <20260823125908.3231362-1-qiwenjie@xiaomi.com>
On 8/23/26 20:59, Wenjie Qi wrote:
> Hi Chao,
>
>> out_err:
>> f2fs_clear_cache_dirty(entry);
>
> Both the inode-checksum and footer-validation failure paths reach this label.
> `f2fs_clear_cache_dirty()` clears the DIRTY state bit, but it does not clear
> UPTODATE or synchronize the DIRTY radix tag and dirty-node counter.
>
> What invariant keeps these states consistent after node validation fails?
Will fix.
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
Wenjie Qi <qiwenjie@xiaomi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v1 07/12] f2fs: cache: use node cache
Date: Mon, 24 Aug 2026 15:13:45 +0800 [thread overview]
Message-ID: <4d408110-0579-4916-9e28-e3e831486980@kernel.org> (raw)
In-Reply-To: <20260823125908.3231362-1-qiwenjie@xiaomi.com>
On 8/23/26 20:59, Wenjie Qi wrote:
> Hi Chao,
>
>> out_err:
>> f2fs_clear_cache_dirty(entry);
>
> Both the inode-checksum and footer-validation failure paths reach this label.
> `f2fs_clear_cache_dirty()` clears the DIRTY state bit, but it does not clear
> UPTODATE or synchronize the DIRTY radix tag and dirty-node counter.
>
> What invariant keeps these states consistent after node validation fails?
Will fix.
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-08-24 7:13 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 3:17 [PATCH v1 00/12] f2fs: introduce metadata cache Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 01/12] f2fs: cache: implement " Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 5:08 ` Jaegeuk Kim
2026-08-20 5:08 ` Jaegeuk Kim via Linux-f2fs-devel
2026-08-20 5:13 ` Chao Yu
2026-08-20 5:13 ` Chao Yu via Linux-f2fs-devel
2026-08-23 12:52 ` Wenjie Qi
2026-08-23 12:52 ` [f2fs-dev] " Wenjie Qi
2026-08-24 7:03 ` Chao Yu
2026-08-24 7:03 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 02/12] f2fs: cache: initialize meta cache Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 03/12] f2fs: cache: introduce shrinker Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 04/12] f2fs: cache: introduce writeback thread Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 5:09 ` Jaegeuk Kim
2026-08-20 5:09 ` Jaegeuk Kim via Linux-f2fs-devel
2026-08-23 12:54 ` Wenjie Qi
2026-08-23 12:54 ` [f2fs-dev] " Wenjie Qi
2026-08-24 7:04 ` Chao Yu
2026-08-24 7:04 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [f2fs-dev] [PATCH v1 05/12] f2fs: cache: use meta cache Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` Chao Yu
2026-08-20 5:11 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-20 5:11 ` Jaegeuk Kim
2026-08-23 12:55 ` Wenjie Qi
2026-08-23 12:55 ` [f2fs-dev] " Wenjie Qi
2026-08-24 7:05 ` Chao Yu
2026-08-24 7:05 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 06/12] f2fs: cache: initialize node cache Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [f2fs-dev] [PATCH v1 07/12] f2fs: cache: use " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` Chao Yu
2026-08-23 12:57 ` Wenjie Qi
2026-08-23 12:57 ` [f2fs-dev] " Wenjie Qi
2026-08-24 7:13 ` Chao Yu
2026-08-24 7:13 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-24 8:57 ` Wenjie Qi
2026-08-24 8:57 ` [f2fs-dev] " Wenjie Qi
2026-08-23 12:59 ` Wenjie Qi
2026-08-23 12:59 ` [f2fs-dev] " Wenjie Qi
2026-08-24 7:13 ` Chao Yu [this message]
2026-08-24 7:13 ` Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 08/12] f2fs: cache: initialize compress cache Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 09/12] f2fs: cache: use " Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 10/12] f2fs: cache: support fault injection Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 11/12] f2fs: cache: introduce tracepoints Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-20 3:17 ` [PATCH v1 12/12] f2fs: cache: show per-cache usage in debugfs Chao Yu
2026-08-20 3:17 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-24 10:07 ` [PATCH v1 00/12] f2fs: introduce metadata cache Wenjie Qi
2026-08-24 10:07 ` [f2fs-dev] " Wenjie Qi
2026-08-28 13:01 ` Chao Yu
2026-08-28 13:01 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d408110-0579-4916-9e28-e3e831486980@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
--cc=qwjhust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.