Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

["Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>]

April 21, 2023 1:01 PM, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> wrote:
>> Ah, got it. So I guess from the perspective of "b4" every time the
>> author modifies a patch (like adding new tags to it) then it's a new
>> application of Signed-off-by and thus the old Signed-off-by is removed
>> from the top and a new one is added below all the tags that have been
>> received. Thus if b4 grabs all the tags off the mailing list for
>> applying it ends up in a different order than if it grabs all the tags
>> off the mailing list for sending a new version.
>> 
>> OK, I can understand that perspective. I'll keep it in mind.
> 
> Yeah. I actually agree with your point that submitter's SoB should
> always be the last one, but I agree more with using process via
> standardized tools. IOW, since I cannot change in this matter b4, I need
> to agree with it. :)

FWIW, everyone disagrees on how it should be done (which is a totally normal state of things). B4 uses the "chain of custody" logic when it comes to trailers, described here:

https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/

In brief, the logic here is that the "Signed-off-by" trailer indicates where the chain of custody for all previous trailers ends. The following order:

Reviewed-by: Reviewer <>
Signed-off-by: Submitter <>
Signed-off-by: Submaintainer <>

Tells that it was the Submitter who collected and applied the Reviewed-by tag, which is why when someone runs "b4 trailers -u", their Signed-off-by is always moved to the bottom to indicate the proper chain of custody boundary.

The following order says something very different:

Signed-off-by: Submitter <>
Reviewed-by: Reviewer <>
Signed-off-by: Submaintainer <>

This indicates that the "Reviewed-by" trailer was collected by the Submaintainer, because it is below the chain-of-custody boundary of the Submitter.

The main reason is if Reviewer says "hey, I don't remember reviewing this, who put my name in there," the order will point at the person in whose custody section this tag shows up.

Hope this helps.

Best regards,
-K