All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>,
	Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Huang Jianan <huangjianan@oppo.com>, Gao Xiang <xiang@kernel.org>,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static
Date: Mon, 9 Aug 2021 07:56:44 +0800	[thread overview]
Message-ID: <4ddfb962-97fc-28b0-0006-197574a1ec00@kernel.org> (raw)
In-Reply-To: <YQ/ZxZkNCtWGO6X4@B-P7TQMD6M-0146.local>

On 2021/8/8 21:19, Gao Xiang wrote:
> On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
>> The sparse tool complains as follows:
>>
>> fs/erofs/data.c:150:24: warning:
>>   symbol 'erofs_iomap_ops' was not declared. Should it be static?
>>
>> This symbol is not used outside of data.c, so marks it static.

Thanks for the patch, I guess it will be better to fix in original patch
if you don't mind.

Thanks,

>>
>> Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Thanks,
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> 
> Thanks,
> Gao Xiang
> 

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>,
	Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hulk Robot <hulkci@huawei.com>, Gao Xiang <xiang@kernel.org>,
	linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static
Date: Mon, 9 Aug 2021 07:56:44 +0800	[thread overview]
Message-ID: <4ddfb962-97fc-28b0-0006-197574a1ec00@kernel.org> (raw)
In-Reply-To: <YQ/ZxZkNCtWGO6X4@B-P7TQMD6M-0146.local>

On 2021/8/8 21:19, Gao Xiang wrote:
> On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
>> The sparse tool complains as follows:
>>
>> fs/erofs/data.c:150:24: warning:
>>   symbol 'erofs_iomap_ops' was not declared. Should it be static?
>>
>> This symbol is not used outside of data.c, so marks it static.

Thanks for the patch, I guess it will be better to fix in original patch
if you don't mind.

Thanks,

>>
>> Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Thanks,
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> 
> Thanks,
> Gao Xiang
> 

  reply	other threads:[~2021-08-08 23:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  6:33 [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static Wei Yongjun
2021-08-08  6:33 ` Wei Yongjun
2021-08-08 13:19 ` Gao Xiang
2021-08-08 13:19   ` Gao Xiang
2021-08-08 23:56   ` Chao Yu [this message]
2021-08-08 23:56     ` Chao Yu
2021-08-09  2:49     ` weiyongjun (A)
2021-08-09  2:49       ` weiyongjun (A)
2021-08-09  3:06       ` Gao Xiang
2021-08-09  3:06         ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ddfb962-97fc-28b0-0006-197574a1ec00@kernel.org \
    --to=chao@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=huangjianan@oppo.com \
    --cc=hulkci@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weiyongjun1@huawei.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.