Re: [PATCH v1.1 6/6] x86/apic: Convert the TSC deadline errata table to X86_MATCH_*()

[Jan Beulich <jbeulich@suse.com>]

On 18.07.2025 12:07, Andrew Cooper wrote:
> With the ability to match on steppings, introduce a new X86_MATCH_VFMS()
> helper to match a specific stepping, and use it to rework deadline_match[].
> 
> Notably this removes the overloading of driver_data possibly being a function
> pointer, and removes the latent bug where the target functions are missing
> ENDBR instructions owing to the lack of the cf_check attribute.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> -static const struct x86_cpu_id __initconstrel deadline_match[] = {

Seeing this transformation ...

>  static void __init check_deadline_errata(void)
>  {
> +    static const struct x86_cpu_id __initconst deadline_match[] = {

... of the section placement, we may want to investigate whether with the
toolchain baseline bump we can actually do away with __initconstrel, using
__initconst uniformly everywhere.

Jan