From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 5/6] x86/match-cpu: Support matching on steppings
Date: Fri, 18 Jul 2025 14:48:12 +0100 [thread overview]
Message-ID: <de067dcd-0464-4df7-b7c3-64acb2c51496@citrix.com> (raw)
In-Reply-To: <48e1c298-0afb-40a3-80a0-a5b97465ce4e@suse.com>
On 18/07/2025 2:28 pm, Jan Beulich wrote:
>>>>>> uint16_t model;
>>>>> Whereas the model is strictly limited to 8 bits.
>>>> There is space in here, if we need it, but you can't shrink it without
>>>> breaking the check for the NULL entry (going back to the first obfuscation).
>>> Breaking? Or merely affecting code generation in a negative way?
>> Shrinking model without adding (and checking) a new field would mean the
>> loop condition no longer covers all metadata.
> And it doesn't strictly need to. It needs to check enough to not mistake a
> valid entry for a sentinel one.
I've found a nicer way of doing this, but it needs another prereq
patch. I'm preparing a v2 with the remainder.
It also addresses the horrible code generation.
~Andrew
next prev parent reply other threads:[~2025-07-18 13:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 17:31 [PATCH 0/6] x86: Convert x86_cpu_id to VFM Andrew Cooper
2025-07-16 17:31 ` [PATCH 1/6] x86: Sort headers Andrew Cooper
2025-07-17 7:10 ` Jan Beulich
2025-07-16 17:31 ` [PATCH 2/6] x86: Break struct x86_cpu_id out of processor.h Andrew Cooper
2025-07-17 7:23 ` Jan Beulich
2025-07-17 17:33 ` Andrew Cooper
2025-07-16 17:31 ` [PATCH 3/6] x86/match-cpu: Introduce X86_MATCH_VFM() and convert intel_idle_ids[] Andrew Cooper
2025-07-17 7:35 ` Jan Beulich
2025-07-17 17:39 ` Andrew Cooper
2025-07-18 5:38 ` Jan Beulich
2025-07-16 17:31 ` [PATCH 4/6] x86: Convert users of INTEL_FAM6_MODEL() to X86_MATCH_VFM() Andrew Cooper
2025-07-17 7:44 ` Jan Beulich
2025-07-17 17:57 ` Andrew Cooper
2025-07-18 5:40 ` Jan Beulich
2025-07-16 17:31 ` [PATCH 5/6] x86/match-cpu: Support matching on steppings Andrew Cooper
2025-07-17 8:11 ` Jan Beulich
2025-07-17 19:39 ` Andrew Cooper
2025-07-18 5:53 ` Jan Beulich
2025-07-18 10:29 ` Andrew Cooper
2025-07-18 13:28 ` Jan Beulich
2025-07-18 13:48 ` Andrew Cooper [this message]
2025-07-16 17:31 ` [PATCH 6/6] x86/apic: Convert the TSC deadline errata table to X86_MATCH_*() Andrew Cooper
2025-07-17 8:26 ` Jan Beulich
2025-07-17 9:02 ` Andrew Cooper
2025-07-17 9:33 ` Jan Beulich
2025-07-17 19:40 ` Andrew Cooper
2025-07-17 8:31 ` Jan Beulich
2025-07-17 19:45 ` Andrew Cooper
2025-07-18 10:07 ` [PATCH v1.1 " Andrew Cooper
2025-07-18 10:19 ` Jan Beulich
2025-07-18 10:23 ` Andrew Cooper
2025-07-18 10:55 ` Andrew Cooper
2025-07-18 14:06 ` Jan Beulich
2025-07-18 14:10 ` Andrew Cooper
2025-07-18 14:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de067dcd-0464-4df7-b7c3-64acb2c51496@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.