From: "Maxime Ripard" <mripard@kernel.org>
To: "David Gow" <davidgow@google.com>
Cc: dlatypov@google.com, dri-devel@lists.freedesktop.org,
kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
llvm@lists.linux.dev, "Arthur Grillo" <arthurgrillo@riseup.net>,
"Benjamin Berg" <benjamin.berg@intel.com>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Emma Anholt" <emma@anholt.net>,
"Kees Cook" <keescook@chromium.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Maíra Canal" <mairacanal@riseup.net>,
"Nathan Chancellor" <nathan@kernel.org>,
"Rae Moar" <rmoar@google.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH 1/3] kunit: Add a macro to wrap a deferred action function
Date: Wed, 15 Nov 2023 15:51:52 +0000 [thread overview]
Message-ID: <4e0c8bb796a67af5fb901f831c5f87fe.mripard@kernel.org> (raw)
In-Reply-To: <20231110200830.1832556-1-davidgow@google.com>
On Sat, 11 Nov 2023 04:08:26 +0800, David Gow wrote:
> KUnit's deferred action API accepts a void(*)(void *) function pointer
> which is called when the test is exited. However, we very frequently
> want to use existing functions which accept a single pointer, but which
> may not be of type void*. While this is probably dodgy enough to be on
> the wrong side of the C standard, it's been often used for similar
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Maxime Ripard" <mripard@kernel.org>
To: "David Gow" <davidgow@google.com>
Cc: "Emma Anholt" <emma@anholt.net>,
dlatypov@google.com, llvm@lists.linux.dev,
"Rae Moar" <rmoar@google.com>,
dri-devel@lists.freedesktop.org,
"Maíra Canal" <mairacanal@riseup.net>,
linux-hardening@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Arthur Grillo" <arthurgrillo@riseup.net>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Benjamin Berg" <benjamin.berg@intel.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
kunit-dev@googlegroups.com,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] kunit: Add a macro to wrap a deferred action function
Date: Wed, 15 Nov 2023 15:51:52 +0000 [thread overview]
Message-ID: <4e0c8bb796a67af5fb901f831c5f87fe.mripard@kernel.org> (raw)
In-Reply-To: <20231110200830.1832556-1-davidgow@google.com>
On Sat, 11 Nov 2023 04:08:26 +0800, David Gow wrote:
> KUnit's deferred action API accepts a void(*)(void *) function pointer
> which is called when the test is exited. However, we very frequently
> want to use existing functions which accept a single pointer, but which
> may not be of type void*. While this is probably dodgy enough to be on
> the wrong side of the C standard, it's been often used for similar
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2023-11-15 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 20:08 [PATCH 1/3] kunit: Add a macro to wrap a deferred action function David Gow
2023-11-10 20:08 ` David Gow
2023-11-10 20:08 ` [PATCH 2/3] drm/tests: Use KUNIT_DEFINE_ACTION_WRAPPER() David Gow
2023-11-10 20:08 ` David Gow
2023-11-15 15:50 ` Maxime Ripard
2023-11-15 15:50 ` Maxime Ripard
2023-11-10 20:08 ` [PATCH 3/3] drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER David Gow
2023-11-10 20:08 ` David Gow
2023-11-15 15:23 ` [PATCH 1/3] kunit: Add a macro to wrap a deferred action function Nathan Chancellor
2023-11-15 15:23 ` Nathan Chancellor
2023-11-15 15:51 ` Maxime Ripard [this message]
2023-11-15 15:51 ` Maxime Ripard
2023-11-15 16:00 ` Daniel Vetter
2023-11-15 16:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0c8bb796a67af5fb901f831c5f87fe.mripard@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=arthurgrillo@riseup.net \
--cc=benjamin.berg@intel.com \
--cc=brendan.higgins@linux.dev \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mairacanal@riseup.net \
--cc=nathan@kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=rmoar@google.com \
--cc=samitolvanen@google.com \
--cc=skhan@linuxfoundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.