Re: [PATCH -mm] Blackfin: blackfin i2c driver

["Sonic Zhang" <sonic.adi@gmail.com>]

On 3/8/07, Jean Delvare <khali@linux-fr.org> wrote:
> Hi Brian,
>
> Thanks for the quick update.



> > +
> > +     rc = (iface->result >= 0) ? 0 : -1;
> > +
> > +     /* Release mutex */
> > +     mutex_unlock(&iface->twi_lock);
> > +
> > +     return rc;
> > +}
>
> i2c-core can emulate SMBus transactions using master_xfer, so in
> general when you have a complete master_xfer implementation you do not
> need to define a separate smbus_xfer function. This would save a lot of
> code.
>

Actually the i2c-core can't emulate SMBus transactions using the
master_xfer function, because the blackfin TWI controller provide
hardware support to the SMBus transactions and the combination of
master_xfer operations can't generate proper signal for SMBus.