From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes"
Date: Tue, 15 Jul 2025 19:03:04 +0200 [thread overview]
Message-ID: <4ea5a054-7e07-4b4c-aa5d-79542c79e89c@kernel.org> (raw)
In-Reply-To: <e33e7262b9c30069bfe9666114ca796707a8324c.camel@kernel.org>
Hi Geliang,
On 15/07/2025 11:52, Geliang Tang wrote:
> Hi Matt,
>
> On Tue, 2025-07-15 at 11:49 +0200, Matthieu Baerts (NGI0) wrote:
>> Without that, all mptcp_connect*.sh subtests have the same name, e.g.
>>
>> mptcp_connect: ping tests ## from mptcp_connect.sh
>> mptcp_connect: ping tests ## from mptcp_connect_checksum.sh
>> mptcp_connect: ping tests ## from mptcp_connect_mmap.sh
>> mptcp_connect: ping tests ## from mptcp_connect_sendfile.sh
>>
>> In such case, the CI will only see one subtest, not 4 different ones.
>>
>> To fix that, MPTCP_LIB_KSFT_TEST env var can simply be set.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> LGTM!
>
> Reviewed-by: Geliang Tang <geliang@kernel.org>
Thank you for the quick review!
Now in our tree:
New patches for t/upstream-net and t/upstream:
- b3ad2903fba4: "squashed" patch 1/2 in "selftests: mptcp: connect: also
cover alt modes"
- 66d7601242b5: "squashed" patch 2/2 in "selftests: mptcp: connect: also
cover checksum"
- Results: c38c723b6c8e..dc8fe14f5e8b (export-net)
- Results: 422cf9363443..a5f1eec0881b (export)
Tests are now in progress:
- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/d202fc514d0d69e212781052c8ca20c6990f11f3/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/8a2039d246ee0028762f2304f8878e433afab20d/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-07-15 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 9:49 [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes" Matthieu Baerts (NGI0)
2025-07-15 9:49 ` [PATCH mptcp-net 1/2] Squash to "selftests: mptcp: connect: also " Matthieu Baerts (NGI0)
2025-07-15 9:49 ` [PATCH mptcp-net 2/2] Squash to "selftests: mptcp: connect: also cover checksum" Matthieu Baerts (NGI0)
2025-07-15 9:52 ` [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes" Geliang Tang
2025-07-15 17:03 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea5a054-7e07-4b4c-aa5d-79542c79e89c@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.