Re: [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes"

[Geliang Tang <geliang@kernel.org>]

Hi Matt,

On Tue, 2025-07-15 at 11:49 +0200, Matthieu Baerts (NGI0) wrote:
> Without that, all mptcp_connect*.sh subtests have the same name, e.g.
> 
>   mptcp_connect: ping tests  ## from mptcp_connect.sh
>   mptcp_connect: ping tests  ## from mptcp_connect_checksum.sh
>   mptcp_connect: ping tests  ## from mptcp_connect_mmap.sh
>   mptcp_connect: ping tests  ## from mptcp_connect_sendfile.sh
> 
> In such case, the CI will only see one subtest, not 4 different ones.
> 
> To fix that, MPTCP_LIB_KSFT_TEST env var can simply be set.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

LGTM!

Reviewed-by: Geliang Tang <geliang@kernel.org>

Thanks,
-Geliang

> ---
> Matthieu Baerts (NGI0) (2):
>       Squash to "selftests: mptcp: connect: also cover alt modes"
>       Squash to "selftests: mptcp: connect: also cover checksum"
> 
>  tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 3 ++-
>  tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh     | 3 ++-
>  tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> ---
> base-commit: 422cf93634436650f6ea5dacb37f1edfed7ab3c9
> change-id: 20250715-selftests-mptcp-connect-modes-fixes-61383574b42a
> 
> Best regards,