From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Randy Dunlap <rdunlap@infradead.org>, Yury Norov <yury.norov@gmail.com>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kees@kernel.org, David Gow <davidgow@google.com>,
John Hubbard <jhubbard@nvidia.com>,
kernel@collabora.com
Subject: Re: [PATCH 2/3] bitmap: Rename module
Date: Tue, 30 Jul 2024 12:51:46 +0500 [thread overview]
Message-ID: <4ed00550-dfc9-4a7b-803a-0a1f5c117d2d@collabora.com> (raw)
In-Reply-To: <c0e5978b-7c11-4657-bd07-9962cd04bf9a@infradead.org>
On 7/29/24 7:09 PM, Randy Dunlap wrote:
>
>
> On 7/29/24 1:07 AM, Muhammad Usama Anjum wrote:
>> On 7/27/24 10:35 PM, Yury Norov wrote:
>>> On Fri, Jul 26, 2024 at 04:06:57PM +0500, Muhammad Usama Anjum wrote:
>>>> Rename module to bitmap_kunit and rename the configuration option
>>>> compliant with kunit framework.
>>>
>>> ... , so those enabling bitmaps testing in their configs by setting
>>> "CONFIG_TEST_BITMAP=y" will suddenly get it broken, and will likely
>>> not realize it until something nasty will happen.
>> CONFIG_TEST_BITMAP was being enabled by the kselftest suite lib. The bitmap
>> test and its config option would disappear. The same test can be run by
>> just enabling KUNIT default config option:
>>
>> KUNIT_ALL_TESTS=y enables this bitmap config by default.
>>
>>>
>>> Sorry, NAK for config rename.
>>>
>
> I agree with Yury. Using KUNIT takes away test coverage for people who
> are willing to run selftests but not use KUNIT.
How is a kselftest useful when it doesn't even check results of the tests
and report failures when they happen?
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-07-30 7:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 11:06 [PATCH 0/3] bitmap: Convert test_bitmap to kunit test Muhammad Usama Anjum
2024-07-26 11:06 ` [PATCH 1/3] bitmap: convert test_bitmap to KUnit test Muhammad Usama Anjum
2024-07-26 11:06 ` [PATCH 2/3] bitmap: Rename module Muhammad Usama Anjum
2024-07-26 18:45 ` John Hubbard
2024-07-29 7:57 ` Muhammad Usama Anjum
2024-07-26 19:24 ` Shuah Khan
2024-07-29 8:02 ` Muhammad Usama Anjum
2024-07-27 17:35 ` Yury Norov
2024-07-29 8:07 ` Muhammad Usama Anjum
2024-07-29 14:09 ` Randy Dunlap
2024-07-30 7:51 ` Muhammad Usama Anjum [this message]
2024-07-30 13:53 ` Randy Dunlap
2024-07-30 10:10 ` David Gow
2024-07-30 15:55 ` Shuah Khan
2024-07-30 18:17 ` Shuah Khan
2024-07-30 18:44 ` John Hubbard
2024-07-30 17:49 ` Yury Norov
2024-07-26 11:06 ` [PATCH 3/3] selftests: lib: remove test_bitmap Muhammad Usama Anjum
2024-07-26 19:22 ` Shuah Khan
2024-07-26 19:26 ` [PATCH 0/3] bitmap: Convert test_bitmap to kunit test Shuah Khan
2024-07-27 18:10 ` Yury Norov
2024-07-29 8:15 ` Muhammad Usama Anjum
2024-07-30 15:39 ` Shuah Khan
2024-07-31 3:05 ` David Gow
2024-07-29 8:29 ` Muhammad Usama Anjum
2024-07-30 15:49 ` Shuah Khan
2024-07-31 3:06 ` David Gow
2024-07-31 16:26 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ed00550-dfc9-4a7b-803a-0a1f5c117d2d@collabora.com \
--to=usama.anjum@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=jhubbard@nvidia.com \
--cc=kees@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rdunlap@infradead.org \
--cc=shuah@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.