[PATCH rtw-next] wifi: rtw88: 8723b: Read the package type from efuse

[PATCH rtw-next] wifi: rtw88: 8723b: Read the package type from efuse

[Bitterblue Smith]

Some chip package types need different parts of the RF initialisation
table, so read the package type from efuse.

Also disable support for 40 MHz channel width based on some other bits
of the same efuse byte. This is not exactly the package type, but the
vendor driver puts it in the same function.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
 drivers/net/wireless/realtek/rtw88/rtw8723b.c | 35 +++++++++++++++++++
 drivers/net/wireless/realtek/rtw88/rtw8723b.h |  8 +++++
 2 files changed, 43 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723b.c b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
index 8bb9c03d769c..fa57900b22fa 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
@@ -6,6 +6,7 @@
 
 #include "main.h"
 #include "coex.h"
+#include "efuse.h"
 #include "fw.h"
 #include "mac.h"
 #include "phy.h"
@@ -2349,6 +2350,38 @@ static void rtw8723b_fill_txdesc_checksum(struct rtw_dev *rtwdev,
 	fill_txdesc_checksum_common(txdesc, 16);
 }
 
+static void rtw8723b_read_package_type(struct rtw_dev *rtwdev)
+{
+	struct rtw_hal *hal = &rtwdev->hal;
+	u8 val_1fb;
+
+	rtw8723b_efuse_grant(rtwdev, true);
+	rtw_read8_physical_efuse(rtwdev, 0x1fb, &val_1fb);
+	rtw8723b_efuse_grant(rtwdev, false);
+
+	switch (u8_get_bits(val_1fb, GENMASK(2, 0))) {
+	case 0x4:
+		hal->pkg_type = RTW8723B_PACKAGE_TFBGA79;
+		break;
+	case 0x5:
+		hal->pkg_type = RTW8723B_PACKAGE_TFBGA90;
+		break;
+	case 0x6:
+		hal->pkg_type = RTW8723B_PACKAGE_QFN68;
+		break;
+	case 0x7:
+		hal->pkg_type = RTW8723B_PACKAGE_TFBGA80;
+		break;
+	default:
+		hal->pkg_type = RTW8723B_PACKAGE_DEFAULT;
+		break;
+	}
+
+	if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO &&
+	    u8_get_bits(val_1fb, GENMASK(5, 4)) == 0x2)
+		rtwdev->efuse.hw_cap.bw &= ~BIT(RTW_CHANNEL_WIDTH_40);
+}
+
 static int rtw8723b_read_efuse(struct rtw_dev *rtwdev, u8 *log_map)
 {
 	struct rtw_efuse *efuse = &rtwdev->efuse;
@@ -2374,6 +2407,8 @@ static int rtw8723b_read_efuse(struct rtw_dev *rtwdev, u8 *log_map)
 	efuse->hw_cap.bw = BIT(RTW_CHANNEL_WIDTH_20) |
 			   BIT(RTW_CHANNEL_WIDTH_40);
 
+	rtw8723b_read_package_type(rtwdev);
+
 	return 0;
 }
 
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723b.h b/drivers/net/wireless/realtek/rtw88/rtw8723b.h
index cf93b93ede81..8201109c18f2 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723b.h
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723b.h
@@ -9,6 +9,14 @@
 
 #include "rtw8723x.h"
 
+enum rtw8723b_package_type {
+	RTW8723B_PACKAGE_DEFAULT,
+	RTW8723B_PACKAGE_QFN68,
+	RTW8723B_PACKAGE_TFBGA90,
+	RTW8723B_PACKAGE_TFBGA80,
+	RTW8723B_PACKAGE_TFBGA79,
+};
+
 extern const struct rtw_chip_info rtw8723b_hw_spec;
 
 #endif
-- 
2.55.0

Re: [PATCH rtw-next] wifi: rtw88: 8723b: Read the package type from efuse

[Luka Gejak]

October 17, 2026 at 5:42 PM, "Bitterblue Smith" <rtl8821cerfe2@gmail.com> wrote:


> 
> Some chip package types need different parts of the RF initialisation
> table, so read the package type from efuse.
> 
> Also disable support for 40 MHz channel width based on some other bits
> of the same efuse byte. This is not exactly the package type, but the
> vendor driver puts it in the same function.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---

Looks good to me, also tested on RTL8723BS.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Tested-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

RE: [PATCH rtw-next] wifi: rtw88: 8723b: Read the package type from efuse

[Ping-Ke Shih]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

[...]

> +static void rtw8723b_read_package_type(struct rtw_dev *rtwdev)
> +{
> +       struct rtw_hal *hal = &rtwdev->hal;
> +       u8 val_1fb;
> +
> +       rtw8723b_efuse_grant(rtwdev, true);
> +       rtw_read8_physical_efuse(rtwdev, 0x1fb, &val_1fb);
> +       rtw8723b_efuse_grant(rtwdev, false);

In rtw_parse_efuse_map(), we can pass 'phy_map' to read_efuse()?
-chip->ops->read_efuse(rtwdev, log_map);
+chip->ops->read_efuse(rtwdev, log_map, phy_map);

As .phy_efuse_size = 512 for RTL7823B, I think it will work. 

> +
> +       switch (u8_get_bits(val_1fb, GENMASK(2, 0))) {

Bit 2~0 seems like PKG_TYPE. Define an enum?

> +       case 0x4:
> +               hal->pkg_type = RTW8723B_PACKAGE_TFBGA79;
> +               break;
> +       case 0x5:
> +               hal->pkg_type = RTW8723B_PACKAGE_TFBGA90;
> +               break;
> +       case 0x6:
> +               hal->pkg_type = RTW8723B_PACKAGE_QFN68;
> +               break;
> +       case 0x7:
> +               hal->pkg_type = RTW8723B_PACKAGE_TFBGA80;
> +               break;
> +       default:
> +               hal->pkg_type = RTW8723B_PACKAGE_DEFAULT;
> +               break;
> +       }
> +
> +       if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO &&
> +           u8_get_bits(val_1fb, GENMASK(5, 4)) == 0x2)

Can you define enums for bit 5-4 and value 0x2?
I'm not sure if vendor driver has some comments pointing out this or not.

> +               rtwdev->efuse.hw_cap.bw &= ~BIT(RTW_CHANNEL_WIDTH_40);
> +}
> +
>  static int rtw8723b_read_efuse(struct rtw_dev *rtwdev, u8 *log_map)
>  {
>         struct rtw_efuse *efuse = &rtwdev->efuse;