From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/11] misc/atmel_tc: make atmel_tc.tcb_config member point to const data
Date: Fri, 13 Jul 2012 15:40:14 +0200 [thread overview]
Message-ID: <5000253E.7050006@atmel.com> (raw)
In-Reply-To: <1342182734-321-6-git-send-email-y>
On 07/13/2012 02:32 PM, y at pengutronix.de :
> From: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>
> This prepares of_device_id.data becoming const. Without this change
> the following warning would occur:
>
> drivers/misc/atmel_tclib.c: In function 'tc_probe':
> drivers/misc/atmel_tclib.c:170: warning: assignment discards qualifiers from pointer target type
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Uwe!
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Hello,
>
> btw, get_maintainer.pl suggested to Cc:
> linux-atm-general at lists.sourceforge.net but not the Atmel people because
> include/linux/atmel_tc.h matches include/linux/atm*.
Ah, ok, good to know. I will try to update MAINTAINERS file for this.
Bye,
> Best regards
> Uwe
> include/linux/atmel_tc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/atmel_tc.h b/include/linux/atmel_tc.h
> index 1d14b1dc..89a931b 100644
> --- a/include/linux/atmel_tc.h
> +++ b/include/linux/atmel_tc.h
> @@ -63,7 +63,7 @@ struct atmel_tc {
> struct platform_device *pdev;
> struct resource *iomem;
> void __iomem *regs;
> - struct atmel_tcb_config *tcb_config;
> + const struct atmel_tcb_config *tcb_config;
> int irq[3];
> struct clk *clk[3];
> struct list_head node;
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: "Greg Kroah-Hartman"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
"Rob Herring"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 04/11] misc/atmel_tc: make atmel_tc.tcb_config member point to const data
Date: Fri, 13 Jul 2012 15:40:14 +0200 [thread overview]
Message-ID: <5000253E.7050006@atmel.com> (raw)
In-Reply-To: <1342182734-321-6-git-send-email-y>
On 07/13/2012 02:32 PM, y@pengutronix.de :
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> This prepares of_device_id.data becoming const. Without this change
> the following warning would occur:
>
> drivers/misc/atmel_tclib.c: In function 'tc_probe':
> drivers/misc/atmel_tclib.c:170: warning: assignment discards qualifiers from pointer target type
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Uwe!
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Hello,
>
> btw, get_maintainer.pl suggested to Cc:
> linux-atm-general@lists.sourceforge.net but not the Atmel people because
> include/linux/atmel_tc.h matches include/linux/atm*.
Ah, ok, good to know. I will try to update MAINTAINERS file for this.
Bye,
> Best regards
> Uwe
> include/linux/atmel_tc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/atmel_tc.h b/include/linux/atmel_tc.h
> index 1d14b1dc..89a931b 100644
> --- a/include/linux/atmel_tc.h
> +++ b/include/linux/atmel_tc.h
> @@ -63,7 +63,7 @@ struct atmel_tc {
> struct platform_device *pdev;
> struct resource *iomem;
> void __iomem *regs;
> - struct atmel_tcb_config *tcb_config;
> + const struct atmel_tcb_config *tcb_config;
> int irq[3];
> struct clk *clk[3];
> struct list_head node;
>
--
Nicolas Ferre
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2012-07-13 13:40 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 12:32 [PATCH 00/11] make struct of_device_id.data const y at pengutronix.de
2012-07-13 12:32 ` [PATCH 0/9] " y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 01/11] spi/imx: make spi_imx_data.devtype_data member point to const data y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 02/11] serial/imx: make imx_port.devdata " y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 03/11] ARM: cache-l2x0: add a const qualifier y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` [PATCH 04/11] misc/atmel_tc: make atmel_tc.tcb_config member point to const data y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 13:40 ` Nicolas Ferre [this message]
2012-07-13 13:40 ` Nicolas Ferre
2012-07-13 12:32 ` [PATCH 05/11] gpio/gpio-omap.c: add a const qualifier y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` [PATCH 06/11] i2c/i2c-omap: " y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 07/11] dmaengine: at_hdmac: add a few const qualifiers y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 13:54 ` Nicolas Ferre
2012-07-13 13:54 ` Nicolas Ferre
2012-07-16 6:38 ` Vinod Koul
2012-07-16 6:38 ` Vinod Koul
2012-07-13 12:32 ` [PATCH 08/11] spi/spi-omap2-mcspi: add a const qualifier y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 09/11] mmc/omap_hsmmc: " y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 10/11] of: add const to struct of_device_id.data y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 11/11] gpio/gpio-omap: make platformdata used as of_device_id.data const y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:39 ` [PATCH 00/11] make struct " Uwe Kleine-König
2012-07-13 12:39 ` Uwe Kleine-König
2012-07-13 12:41 ` Rob Herring
2012-07-13 12:41 ` Rob Herring
2012-07-13 13:46 ` Uwe Kleine-König
2012-07-13 13:46 ` Uwe Kleine-König
2012-07-13 16:24 ` Arnd Bergmann
2012-07-13 16:24 ` Arnd Bergmann
2012-07-13 17:49 ` Uwe Kleine-König
2012-07-13 17:49 ` Uwe Kleine-König
2012-07-13 18:56 ` Arnd Bergmann
2012-07-13 18:56 ` Arnd Bergmann
2012-07-13 19:48 ` Rob Herring
2012-07-13 19:48 ` Rob Herring
2012-07-13 19:36 ` Grant Likely
2012-07-13 19:36 ` Grant Likely
2012-07-14 18:31 ` Uwe Kleine-König
2012-07-14 18:31 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5000253E.7050006@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.