All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <b04825@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
Date: Fri, 13 Jul 2012 17:22:29 -0500	[thread overview]
Message-ID: <50009FA5.4070903@freescale.com> (raw)
In-Reply-To: <50009EE6.2080804@freescale.com>

Scott Wood wrote:

> I know the spec wouldn't change, except the version number.  But as I
> said above, there would be no known v2 implementations with the bug.
> You would only check the bad CRC location if you see v1 data, because
> there are known buggy v1 implementations.

I already have that:

	if ((e.version == NXID_VERSION) && (crc != be32_to_cpup(crcp))) {

NXID_VERSION is equal to 1, so we only do the check for the old CRC if we
have a v1 EEPROM.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-07-13 22:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 21:46 [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location Timur Tabi
2012-07-12 22:03 ` sun york-R58495
2012-07-12 22:37   ` Scott Wood
2012-07-12 22:44     ` Timur Tabi
2012-07-12 22:46     ` sun york-R58495
2012-07-12 22:49       ` Scott Wood
2012-07-12 22:52         ` Timur Tabi
2012-07-13  4:32           ` Wolfgang Denk
2012-07-13 12:11             ` Tabi Timur-B04825
2012-07-13 21:26               ` Wolfgang Denk
2012-07-13  4:30   ` Wolfgang Denk
2012-07-13  4:38     ` sun york-R58495
2012-07-13 12:12       ` Tabi Timur-B04825
2012-07-13 21:22         ` York Sun
2012-07-13 12:10     ` Tabi Timur-B04825
2012-07-13 21:25       ` Wolfgang Denk
2012-07-13 21:29         ` Timur Tabi
2012-07-13 21:32           ` Wolfgang Denk
2012-07-13 21:39             ` Timur Tabi
2012-07-13 21:45         ` Scott Wood
2012-07-13 21:53           ` Timur Tabi
2012-07-13 22:19             ` Scott Wood
2012-07-13 22:22               ` Timur Tabi [this message]
2012-07-13 22:41                 ` Scott Wood
2012-07-13 22:46                   ` Timur Tabi
2012-07-13 22:54                     ` Scott Wood
2012-07-13 23:01             ` Wolfgang Denk
2012-07-13 23:12               ` Scott Wood
     [not found]                 ` <C5EFF1F960B6FC4C873CF9BD5FE250210791DCC8@039-SN2MPN1-013.039d.mgd.msft.net>
2012-07-15 12:52                   ` Tabi Timur-B04825
2012-07-16 19:57                 ` Wolfgang Denk
2012-07-16 22:32                   ` Scott Wood
2012-07-13 22:59           ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50009FA5.4070903@freescale.com \
    --to=b04825@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.