From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
Date: Fri, 13 Jul 2012 18:12:03 -0500 [thread overview]
Message-ID: <5000AB43.6090406@freescale.com> (raw)
In-Reply-To: <20120713230100.5E9C1200320@gemini.denx.de>
On 07/13/2012 06:01 PM, Wolfgang Denk wrote:
> Dear Timur Tabi,
>
> In message <500098F6.8050702@freescale.com> you wrote:
>>
>> I honestly don't see what's wrong with checking the CRC in the old
>> location, and using it if it's valid. Like I said, we already
>
> You are interpreting something which can be random data.
>
>> if (e.version == 0)
>> crc_offset = 0x72;
>>
>> So here we're reading the 'version' field before we validate the data,
>> because we need to check the version to know where the CRC is.
>
> Argh. More crap ...
And how would you do it? You have to look at *something* first, and
whatever that is could be a coincidence if you think people are going to
stuff arbitrary data into the EEPROM.
-Scott
next prev parent reply other threads:[~2012-07-13 23:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 21:46 [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location Timur Tabi
2012-07-12 22:03 ` sun york-R58495
2012-07-12 22:37 ` Scott Wood
2012-07-12 22:44 ` Timur Tabi
2012-07-12 22:46 ` sun york-R58495
2012-07-12 22:49 ` Scott Wood
2012-07-12 22:52 ` Timur Tabi
2012-07-13 4:32 ` Wolfgang Denk
2012-07-13 12:11 ` Tabi Timur-B04825
2012-07-13 21:26 ` Wolfgang Denk
2012-07-13 4:30 ` Wolfgang Denk
2012-07-13 4:38 ` sun york-R58495
2012-07-13 12:12 ` Tabi Timur-B04825
2012-07-13 21:22 ` York Sun
2012-07-13 12:10 ` Tabi Timur-B04825
2012-07-13 21:25 ` Wolfgang Denk
2012-07-13 21:29 ` Timur Tabi
2012-07-13 21:32 ` Wolfgang Denk
2012-07-13 21:39 ` Timur Tabi
2012-07-13 21:45 ` Scott Wood
2012-07-13 21:53 ` Timur Tabi
2012-07-13 22:19 ` Scott Wood
2012-07-13 22:22 ` Timur Tabi
2012-07-13 22:41 ` Scott Wood
2012-07-13 22:46 ` Timur Tabi
2012-07-13 22:54 ` Scott Wood
2012-07-13 23:01 ` Wolfgang Denk
2012-07-13 23:12 ` Scott Wood [this message]
[not found] ` <C5EFF1F960B6FC4C873CF9BD5FE250210791DCC8@039-SN2MPN1-013.039d.mgd.msft.net>
2012-07-15 12:52 ` Tabi Timur-B04825
2012-07-16 19:57 ` Wolfgang Denk
2012-07-16 22:32 ` Scott Wood
2012-07-13 22:59 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5000AB43.6090406@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.