From: Felix Fietkau <nbd@openwrt.org>
To: "Manoharan, Sujith" <c_manoha@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"Rodriguez, Luis" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH v2 08/12] ath9k: fix aggregate size limit based on queue TXOP limit
Date: Sun, 15 Jul 2012 13:21:22 +0200 [thread overview]
Message-ID: <5002A7B2.409@openwrt.org> (raw)
In-Reply-To: <506697F5827BD842B7CB80D046EBE618995399@aphydexd01b>
On 2012-07-15 4:21 AM, Manoharan, Sujith wrote:
> I believe mac80211 has a per-VIF idea of queue parameters (tx_conf in struct ieee80211_sub_if_data).
> And we end up overwriting the parameters of the main interface. For example,
>
> * Bringing up an AP interface:
>
> ath: phy0: Configure tx [queue/halq] [0/0], aifs: 1, cw_min: 3, cw_max: 7, txop: 47
> ath: phy0: Configure tx [queue/halq] [1/1], aifs: 1, cw_min: 7, cw_max: 15, txop: 94
> ath: phy0: Configure tx [queue/halq] [2/2], aifs: 3, cw_min: 15, cw_max: 63, txop: 0
> ath: phy0: Configure tx [queue/halq] [3/3], aifs: 7, cw_min: 15, cw_max: 1023, txop: 0
>
> * Adding a new station interface (but not associated yet):
>
> ath: phy0: Attach a VIF of type: 2
>
> ath: phy0: Configure tx [queue/halq] [0/0], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0
> ath: phy0: Configure tx [queue/halq] [1/1], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0
> ath: phy0: Configure tx [queue/halq] [2/2], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0
> ath: phy0: Configure tx [queue/halq] [3/3], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0
Yes, but ath9k only has global queue settings, not per-vif ones, so I'm
not sure what can be done about the issue of overwriting queue settings.
Either way, it's important for the aggregation limit to be in sync with
the hardware queue TXOP limit, so I believe this patch is correct.
- Felix
next prev parent reply other threads:[~2012-07-15 11:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 15:04 [PATCH v2 01/12] ath9k_hw: fall back to OTP ROM when platform data has no valid eeprom data Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 02/12] ath9k: validate rx antenna settings Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 03/12] ath9k_hw: enable ANI on AR934x Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 04/12] ath9k_hw: fix tx gain tables for AR934x Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 05/12] ath9k_hw: remove redundant arguments to INIT_INI_ARRAY Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 06/12] ath9k/ath9k_htc: fix txop limit handling Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 07/12] ath9k: make per-WMM-AC queue sizes configurable via debugfs Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 08/12] ath9k: fix aggregate size limit based on queue TXOP limit Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 09/12] ath9k_hw: apply XPA timing control values from EEPROM Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 10/12] ath9k_hw: clean up AR9003 EEPROM code Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 11/12] ath9k_hw: apply XLNA bias settings from EEPROM Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 12/12] ath9k_hw: fix SREV checks for applying tuning caps " Felix Fietkau
2012-07-14 6:04 ` [PATCH v2 08/12] ath9k: fix aggregate size limit based on queue TXOP limit Sujith Manoharan
2012-07-14 10:02 ` Felix Fietkau
2012-07-15 2:21 ` Manoharan, Sujith
2012-07-15 11:21 ` Felix Fietkau [this message]
2012-07-16 8:15 ` Sujith Manoharan
2012-07-16 10:19 ` Felix Fietkau
2012-07-16 18:28 ` Sujith Manoharan
2012-07-16 19:24 ` Felix Fietkau
2012-07-17 11:35 ` Sujith Manoharan
2012-07-17 11:54 ` Felix Fietkau
2012-07-15 17:53 ` [PATCH v2 05/12] ath9k_hw: remove redundant arguments to INIT_INI_ARRAY Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5002A7B2.409@openwrt.org \
--to=nbd@openwrt.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.