From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"Rodriguez, Luis" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH v2 08/12] ath9k: fix aggregate size limit based on queue TXOP limit
Date: Tue, 17 Jul 2012 13:54:30 +0200 [thread overview]
Message-ID: <50055276.20304@openwrt.org> (raw)
In-Reply-To: <20485.19956.285571.372831@gargle.gargle.HOWL>
On 2012-07-17 1:35 PM, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> The way I understand this, the TXOP limit is meant to limit the duration
>> of a single transmission on the channel. An aggregate is transmitted in
>> one go, there's no SIFS or extra PHY headers inbetween, just short
>> delimiters. So an A-MPDU should be treated pretty much like an MPDU
>> here, its transmission duration should not exceed the TXOP limit.
>
> Yeah, makes sense.
>
> But we need to handle multiple interfaces, otherwise this would break
> modes like P2P. For example, bring up a P2P-GO and setup a HT20 network,
> and then bring up a new station interface - this would unconditionally
> update the aggr. limits of the existing network. This wasn't the case earlier
> since the limits were being maintained globally and were common to all interfaces
> and addition/removal of new interfaces would not change the aggr. limits.
Before my patch, the aggr limits were always broken for the VI queue.
Now they're just sometimes broken :)
- Felix
next prev parent reply other threads:[~2012-07-17 11:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 15:04 [PATCH v2 01/12] ath9k_hw: fall back to OTP ROM when platform data has no valid eeprom data Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 02/12] ath9k: validate rx antenna settings Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 03/12] ath9k_hw: enable ANI on AR934x Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 04/12] ath9k_hw: fix tx gain tables for AR934x Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 05/12] ath9k_hw: remove redundant arguments to INIT_INI_ARRAY Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 06/12] ath9k/ath9k_htc: fix txop limit handling Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 07/12] ath9k: make per-WMM-AC queue sizes configurable via debugfs Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 08/12] ath9k: fix aggregate size limit based on queue TXOP limit Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 09/12] ath9k_hw: apply XPA timing control values from EEPROM Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 10/12] ath9k_hw: clean up AR9003 EEPROM code Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 11/12] ath9k_hw: apply XLNA bias settings from EEPROM Felix Fietkau
2012-07-12 15:04 ` [PATCH v2 12/12] ath9k_hw: fix SREV checks for applying tuning caps " Felix Fietkau
2012-07-14 6:04 ` [PATCH v2 08/12] ath9k: fix aggregate size limit based on queue TXOP limit Sujith Manoharan
2012-07-14 10:02 ` Felix Fietkau
2012-07-15 2:21 ` Manoharan, Sujith
2012-07-15 11:21 ` Felix Fietkau
2012-07-16 8:15 ` Sujith Manoharan
2012-07-16 10:19 ` Felix Fietkau
2012-07-16 18:28 ` Sujith Manoharan
2012-07-16 19:24 ` Felix Fietkau
2012-07-17 11:35 ` Sujith Manoharan
2012-07-17 11:54 ` Felix Fietkau [this message]
2012-07-15 17:53 ` [PATCH v2 05/12] ath9k_hw: remove redundant arguments to INIT_INI_ARRAY Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50055276.20304@openwrt.org \
--to=nbd@openwrt.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.