* [PATCH V2 0/2] correct ids for clk_testout @ 2017-04-25 6:41 ` Eddie Cai 0 siblings, 0 replies; 13+ messages in thread From: Eddie Cai @ 2017-04-25 6:41 UTC (permalink / raw) To: robh+dt, mark.rutland, heiko, zhengxing, mturquette, sboyd Cc: devicetree, linux-kernel, linux-clk, linux-arm-kernel, linux-rockchip, Eddie Cai we use clk_testout1 and clk_testout2 for camera. e.g. mipi 24M mclk. the ids of clk_testout1 and clk_testout2 is wrong. it's time to correct it. Eddie Cai (2): clk: rockchip: add ids for camera clk: rockchip: fix the incorrect ids drivers/clk/rockchip/clk-rk3399.c | 4 ++-- include/dt-bindings/clock/rk3399-cru.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH V2 0/2] correct ids for clk_testout @ 2017-04-25 6:41 ` Eddie Cai 0 siblings, 0 replies; 13+ messages in thread From: Eddie Cai @ 2017-04-25 6:41 UTC (permalink / raw) To: linux-arm-kernel we use clk_testout1 and clk_testout2 for camera. e.g. mipi 24M mclk. the ids of clk_testout1 and clk_testout2 is wrong. it's time to correct it. Eddie Cai (2): clk: rockchip: add ids for camera clk: rockchip: fix the incorrect ids drivers/clk/rockchip/clk-rk3399.c | 4 ++-- include/dt-bindings/clock/rk3399-cru.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH V2 0/2] correct ids for clk_testout @ 2017-04-25 6:41 ` Eddie Cai 0 siblings, 0 replies; 13+ messages in thread From: Eddie Cai @ 2017-04-25 6:41 UTC (permalink / raw) To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, heiko-4mtYJXux2i+zQB+pC5nmwQ, zhengxing-TNX95d0MmH7DzftRWevZcw, mturquette-rdvid1DuHRBWk0Htik3J/w, sboyd-sgV2jX0FEOL9JmXXK+q4OQ Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-clk-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Eddie Cai we use clk_testout1 and clk_testout2 for camera. e.g. mipi 24M mclk. the ids of clk_testout1 and clk_testout2 is wrong. it's time to correct it. Eddie Cai (2): clk: rockchip: add ids for camera clk: rockchip: fix the incorrect ids drivers/clk/rockchip/clk-rk3399.c | 4 ++-- include/dt-bindings/clock/rk3399-cru.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH V2 1/2] clk: rockchip: add ids for camera 2017-04-25 6:41 ` Eddie Cai @ 2017-04-25 6:41 ` Eddie Cai -1 siblings, 0 replies; 13+ messages in thread From: Eddie Cai @ 2017-04-25 6:41 UTC (permalink / raw) To: robh+dt, mark.rutland, heiko, zhengxing, mturquette, sboyd Cc: devicetree, linux-kernel, linux-clk, linux-arm-kernel, linux-rockchip, Eddie Cai we use SCLK_TESTCLKOUT1 and SCLK_TESTCLKOUT2 for camera, so add those ids. Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> --- include/dt-bindings/clock/rk3399-cru.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/clock/rk3399-cru.h index 220a60f..22cb1df 100644 --- a/include/dt-bindings/clock/rk3399-cru.h +++ b/include/dt-bindings/clock/rk3399-cru.h @@ -132,6 +132,8 @@ #define SCLK_RMII_SRC 166 #define SCLK_PCIEPHY_REF100M 167 #define SCLK_DDRC 168 +#define SCLK_TESTCLKOUT1 169 +#define SCLK_TESTCLKOUT2 170 #define DCLK_VOP0 180 #define DCLK_VOP1 181 -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH V2 1/2] clk: rockchip: add ids for camera @ 2017-04-25 6:41 ` Eddie Cai 0 siblings, 0 replies; 13+ messages in thread From: Eddie Cai @ 2017-04-25 6:41 UTC (permalink / raw) To: linux-arm-kernel we use SCLK_TESTCLKOUT1 and SCLK_TESTCLKOUT2 for camera, so add those ids. Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> --- include/dt-bindings/clock/rk3399-cru.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/clock/rk3399-cru.h index 220a60f..22cb1df 100644 --- a/include/dt-bindings/clock/rk3399-cru.h +++ b/include/dt-bindings/clock/rk3399-cru.h @@ -132,6 +132,8 @@ #define SCLK_RMII_SRC 166 #define SCLK_PCIEPHY_REF100M 167 #define SCLK_DDRC 168 +#define SCLK_TESTCLKOUT1 169 +#define SCLK_TESTCLKOUT2 170 #define DCLK_VOP0 180 #define DCLK_VOP1 181 -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH V2 1/2] clk: rockchip: add ids for camera 2017-04-25 6:41 ` Eddie Cai @ 2017-05-17 17:56 ` Heiko Stuebner -1 siblings, 0 replies; 13+ messages in thread From: Heiko Stuebner @ 2017-05-17 17:56 UTC (permalink / raw) To: Eddie Cai Cc: robh+dt, mark.rutland, zhengxing, mturquette, sboyd, devicetree, linux-kernel, linux-clk, linux-arm-kernel, linux-rockchip Am Dienstag, 25. April 2017, 14:41:09 CEST schrieb Eddie Cai: > we use SCLK_TESTCLKOUT1 and SCLK_TESTCLKOUT2 for camera, so add those ids. > > Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> applied for 4.13 Thanks Heiko ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH V2 1/2] clk: rockchip: add ids for camera @ 2017-05-17 17:56 ` Heiko Stuebner 0 siblings, 0 replies; 13+ messages in thread From: Heiko Stuebner @ 2017-05-17 17:56 UTC (permalink / raw) To: linux-arm-kernel Am Dienstag, 25. April 2017, 14:41:09 CEST schrieb Eddie Cai: > we use SCLK_TESTCLKOUT1 and SCLK_TESTCLKOUT2 for camera, so add those ids. > > Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> applied for 4.13 Thanks Heiko ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH V2 2/2] clk: rockchip: fix the incorrect ids 2017-04-25 6:41 ` Eddie Cai @ 2017-04-25 6:41 ` Eddie Cai -1 siblings, 0 replies; 13+ messages in thread From: Eddie Cai @ 2017-04-25 6:41 UTC (permalink / raw) To: robh+dt, mark.rutland, heiko, zhengxing, mturquette, sboyd Cc: devicetree, linux-kernel, linux-clk, linux-arm-kernel, linux-rockchip, Eddie Cai the ids of clk_testout1 and clk_testout2 is incorrect now. let's correct it Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> --- drivers/clk/rockchip/clk-rk3399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index 73121b14..f3656ba 100644 --- a/drivers/clk/rockchip/clk-rk3399.c +++ b/drivers/clk/rockchip/clk-rk3399.c @@ -1066,13 +1066,13 @@ enum rk3399_pmu_plls { /* cif_testout */ MUX(0, "clk_testout1_pll_src", mux_pll_src_cpll_gpll_npll_p, 0, RK3399_CLKSEL_CON(38), 6, 2, MFLAGS), - COMPOSITE(0, "clk_testout1", mux_clk_testout1_p, 0, + COMPOSITE(SCLK_TESTCLKOUT1, "clk_testout1", mux_clk_testout1_p, 0, RK3399_CLKSEL_CON(38), 5, 1, MFLAGS, 0, 5, DFLAGS, RK3399_CLKGATE_CON(13), 14, GFLAGS), MUX(0, "clk_testout2_pll_src", mux_pll_src_cpll_gpll_npll_p, 0, RK3399_CLKSEL_CON(38), 14, 2, MFLAGS), - COMPOSITE(0, "clk_testout2", mux_clk_testout2_p, 0, + COMPOSITE(SCLK_TESTCLKOUT2, "clk_testout2", mux_clk_testout2_p, 0, RK3399_CLKSEL_CON(38), 13, 1, MFLAGS, 8, 5, DFLAGS, RK3399_CLKGATE_CON(13), 15, GFLAGS), -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH V2 2/2] clk: rockchip: fix the incorrect ids @ 2017-04-25 6:41 ` Eddie Cai 0 siblings, 0 replies; 13+ messages in thread From: Eddie Cai @ 2017-04-25 6:41 UTC (permalink / raw) To: linux-arm-kernel the ids of clk_testout1 and clk_testout2 is incorrect now. let's correct it Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> --- drivers/clk/rockchip/clk-rk3399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index 73121b14..f3656ba 100644 --- a/drivers/clk/rockchip/clk-rk3399.c +++ b/drivers/clk/rockchip/clk-rk3399.c @@ -1066,13 +1066,13 @@ enum rk3399_pmu_plls { /* cif_testout */ MUX(0, "clk_testout1_pll_src", mux_pll_src_cpll_gpll_npll_p, 0, RK3399_CLKSEL_CON(38), 6, 2, MFLAGS), - COMPOSITE(0, "clk_testout1", mux_clk_testout1_p, 0, + COMPOSITE(SCLK_TESTCLKOUT1, "clk_testout1", mux_clk_testout1_p, 0, RK3399_CLKSEL_CON(38), 5, 1, MFLAGS, 0, 5, DFLAGS, RK3399_CLKGATE_CON(13), 14, GFLAGS), MUX(0, "clk_testout2_pll_src", mux_pll_src_cpll_gpll_npll_p, 0, RK3399_CLKSEL_CON(38), 14, 2, MFLAGS), - COMPOSITE(0, "clk_testout2", mux_clk_testout2_p, 0, + COMPOSITE(SCLK_TESTCLKOUT2, "clk_testout2", mux_clk_testout2_p, 0, RK3399_CLKSEL_CON(38), 13, 1, MFLAGS, 8, 5, DFLAGS, RK3399_CLKGATE_CON(13), 15, GFLAGS), -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] clk: rockchip: fix the incorrect ids 2017-04-25 6:41 ` Eddie Cai @ 2017-05-17 17:57 ` Heiko Stuebner -1 siblings, 0 replies; 13+ messages in thread From: Heiko Stuebner @ 2017-05-17 17:57 UTC (permalink / raw) To: Eddie Cai Cc: robh+dt, mark.rutland, zhengxing, mturquette, sboyd, devicetree, linux-kernel, linux-clk, linux-arm-kernel, linux-rockchip Am Dienstag, 25. April 2017, 14:41:10 CEST schrieb Eddie Cai: > the ids of clk_testout1 and clk_testout2 is incorrect now. let's correct it > > Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> applied for 4.13, after fixing the subject up a bit [the old ids are not incorrect, there simply weren't any assigned to the testclks yet :-) ] Thanks Heiko ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH V2 2/2] clk: rockchip: fix the incorrect ids @ 2017-05-17 17:57 ` Heiko Stuebner 0 siblings, 0 replies; 13+ messages in thread From: Heiko Stuebner @ 2017-05-17 17:57 UTC (permalink / raw) To: linux-arm-kernel Am Dienstag, 25. April 2017, 14:41:10 CEST schrieb Eddie Cai: > the ids of clk_testout1 and clk_testout2 is incorrect now. let's correct it > > Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> applied for 4.13, after fixing the subject up a bit [the old ids are not incorrect, there simply weren't any assigned to the testclks yet :-) ] Thanks Heiko ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 0/2] correct ids for clk_testout 2017-04-25 6:41 ` Eddie Cai @ 2017-04-25 21:04 ` Heiko Stübner -1 siblings, 0 replies; 13+ messages in thread From: Heiko Stübner @ 2017-04-25 21:04 UTC (permalink / raw) To: Eddie Cai Cc: robh+dt, mark.rutland, zhengxing, mturquette, sboyd, devicetree, linux-kernel, linux-clk, linux-arm-kernel, linux-rockchip Hi Eddie, Am Dienstag, 25. April 2017, 14:41:08 CEST schrieb Eddie Cai: > we use clk_testout1 and clk_testout2 for camera. e.g. mipi 24M mclk. the ids > of clk_testout1 and clk_testout2 is wrong. it's time to correct it. Just to say, patches look good - thanks for explaining what the clocks are going to be used for. I'll apply them after 4.12-rc1 is released (in roughly 2.5 weeks), due to needing a stable base for the clock-ids. Heiko ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH V2 0/2] correct ids for clk_testout @ 2017-04-25 21:04 ` Heiko Stübner 0 siblings, 0 replies; 13+ messages in thread From: Heiko Stübner @ 2017-04-25 21:04 UTC (permalink / raw) To: linux-arm-kernel Hi Eddie, Am Dienstag, 25. April 2017, 14:41:08 CEST schrieb Eddie Cai: > we use clk_testout1 and clk_testout2 for camera. e.g. mipi 24M mclk. the ids > of clk_testout1 and clk_testout2 is wrong. it's time to correct it. Just to say, patches look good - thanks for explaining what the clocks are going to be used for. I'll apply them after 4.12-rc1 is released (in roughly 2.5 weeks), due to needing a stable base for the clock-ids. Heiko ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-05-17 17:57 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-04-25 6:41 [PATCH V2 0/2] correct ids for clk_testout Eddie Cai 2017-04-25 6:41 ` Eddie Cai 2017-04-25 6:41 ` Eddie Cai 2017-04-25 6:41 ` [PATCH V2 1/2] clk: rockchip: add ids for camera Eddie Cai 2017-04-25 6:41 ` Eddie Cai 2017-05-17 17:56 ` Heiko Stuebner 2017-05-17 17:56 ` Heiko Stuebner 2017-04-25 6:41 ` [PATCH V2 2/2] clk: rockchip: fix the incorrect ids Eddie Cai 2017-04-25 6:41 ` Eddie Cai 2017-05-17 17:57 ` Heiko Stuebner 2017-05-17 17:57 ` Heiko Stuebner 2017-04-25 21:04 ` [PATCH V2 0/2] correct ids for clk_testout Heiko Stübner 2017-04-25 21:04 ` Heiko Stübner
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.