All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Alexey Charkov <alchark@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
Date: Fri, 20 Jun 2025 10:44:14 +0200	[thread overview]
Message-ID: <5004008.8F6SAcFxjW@phil> (raw)
In-Reply-To: <CABjd4Yzz9mh0G5BhpPOGAoadD-A5eX4kdsF8rGrWk82hAE-MYQ@mail.gmail.com>

Am Freitag, 20. Juni 2025, 10:40:49 Mitteleuropäische Sommerzeit schrieb Alexey Charkov:
> On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> >
> > On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> > >
> > > Different board versions use different incompatible WiFi/Bluetooth modules
> > > so split the version-specific bits out into an overlay. Basic WiFi
> > > functionality works even without an overlay, but OOB interrupts and
> > > all Bluetooth stuff requires one.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> >       commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
> > [2/4] arm64: dts: rockchip: add SDIO controller on RK3576
> >       commit: e490f854b46369b096f3d09c0c6a00f340425136
> > [3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> >       commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
> > [4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> >       commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63
> >
> > Patch 1 as fix for v6.16
> >
> > I've also fixed the wifi@1 node in the overlay - which was using
> > spaces instead of tabs.
> 
> Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
> from binding examples is not a universally good idea :)
> 
> By the way, is there any tool that helps catch those?

checkpatch.pl would be the tool to do that, but I'm not sure it handles
this at this time.

I also only saw things when I looked at the patch in "mcedit", because
it nicely distinguishes between tabs and spaces :-) .






WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Alexey Charkov <alchark@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Detlev Casanova <detlev.casanova@collabora.com>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
Date: Fri, 20 Jun 2025 10:44:14 +0200	[thread overview]
Message-ID: <5004008.8F6SAcFxjW@phil> (raw)
In-Reply-To: <CABjd4Yzz9mh0G5BhpPOGAoadD-A5eX4kdsF8rGrWk82hAE-MYQ@mail.gmail.com>

Am Freitag, 20. Juni 2025, 10:40:49 Mitteleuropäische Sommerzeit schrieb Alexey Charkov:
> On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> >
> > On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> > >
> > > Different board versions use different incompatible WiFi/Bluetooth modules
> > > so split the version-specific bits out into an overlay. Basic WiFi
> > > functionality works even without an overlay, but OOB interrupts and
> > > all Bluetooth stuff requires one.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> >       commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
> > [2/4] arm64: dts: rockchip: add SDIO controller on RK3576
> >       commit: e490f854b46369b096f3d09c0c6a00f340425136
> > [3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> >       commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
> > [4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> >       commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63
> >
> > Patch 1 as fix for v6.16
> >
> > I've also fixed the wifi@1 node in the overlay - which was using
> > spaces instead of tabs.
> 
> Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
> from binding examples is not a universally good idea :)
> 
> By the way, is there any tool that helps catch those?

checkpatch.pl would be the tool to do that, but I'm not sure it handles
this at this time.

I also only saw things when I looked at the patch in "mcedit", because
it nicely distinguishes between tabs and spaces :-) .





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-06-20  9:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-14 18:14 [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Alexey Charkov
2025-06-14 18:14 ` Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 1/4] arm64: dts: rockchip: list all CPU supplies " Alexey Charkov
2025-06-14 18:14   ` Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 2/4] arm64: dts: rockchip: add SDIO controller on RK3576 Alexey Charkov
2025-06-14 18:14   ` Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5 Alexey Charkov
2025-06-14 18:14   ` Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2 Alexey Charkov
2025-06-14 18:14   ` Alexey Charkov
2025-06-16 21:46 ` [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Rob Herring (Arm)
2025-06-16 21:46   ` Rob Herring (Arm)
2025-06-17  6:54   ` Alexey Charkov
2025-06-17  6:54     ` Alexey Charkov
2025-06-19 21:17 ` Heiko Stuebner
2025-06-19 21:17   ` Heiko Stuebner
2025-06-20  8:40   ` Alexey Charkov
2025-06-20  8:40     ` Alexey Charkov
2025-06-20  8:44     ` Heiko Stuebner [this message]
2025-06-20  8:44       ` Heiko Stuebner
2025-06-20 10:10       ` Diederik de Haas
2025-06-20 10:10         ` Diederik de Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5004008.8F6SAcFxjW@phil \
    --to=heiko@sntech.de \
    --cc=alchark@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.