All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][scarthgap][PATCH] lmsensors: Fix build without sensord
@ 2025-05-05  9:56 Leonard Anderweit
  2025-05-15 14:52 ` [oe] " Alexander Stein
  0 siblings, 1 reply; 3+ messages in thread
From: Leonard Anderweit @ 2025-05-05  9:56 UTC (permalink / raw)
  To: openembedded-devel; +Cc: upstream

When building with sensord disabled (PACKAGECONFIG = ""), do_install
would fail because it tried to build sensord which was skiped in
do_compile.
Error log:
make: *** No rule to make target 'rrd.h', needed by 'prog/sensord/rrd.rd'. Stop.

Avoid building sensord in do_install by explicitly setting PROG_EXTRA.

(master rev: fc88c96c4e40d9dbc6097c4679ac79ed55356730)

Fixes: 86b20b84ec27 (lmsensors: Clean stale files for sensord to avoid
incorrect GCC header dependencies)

Signed-off-by: Leonard Anderweit <l.anderweit@phytec.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
index e3186132c76c..6e4cf29f479f 100644
--- a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
+++ b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
@@ -48,7 +48,8 @@ S = "${WORKDIR}/git"
 EXTRA_OEMAKE = 'EXLDFLAGS="${LDFLAGS}" \
         MACHINE=${TARGET_ARCH} PREFIX=${prefix} MANDIR=${mandir} \
         LIBDIR=${libdir} \
-        CC="${CC}" AR="${AR}"'
+        CC="${CC}" AR="${AR}" \
+        PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"'
 
 do_configure:prepend() {
     sed -i -e 's:^#\(PROG_EXTRA\):\1:' ${S}/Makefile
@@ -59,7 +60,7 @@ do_compile() {
     sed -i -e 's/\$(LIBDIR)$/\$(LIBDIR) \$(LDFLAGS)/g' ${S}/Makefile
     sed -i -e 's/\$(LIBSHSONAME) -o/$(LIBSHSONAME) \$(LDFLAGS) -o/g' \
                 ${S}/lib/Module.mk
-    oe_runmake user PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"
+    oe_runmake user
 }
 
 do_install() {
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [oe] [meta-oe][scarthgap][PATCH] lmsensors: Fix build without sensord
  2025-05-05  9:56 [meta-oe][scarthgap][PATCH] lmsensors: Fix build without sensord Leonard Anderweit
@ 2025-05-15 14:52 ` Alexander Stein
  2025-05-26  6:32   ` Alexander Stein
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Stein @ 2025-05-15 14:52 UTC (permalink / raw)
  To: openembedded-devel; +Cc: upstream, L.Anderweit

Am Montag, 5. Mai 2025, 11:56:20 CEST schrieb Leonard Anderweit via lists.openembedded.org:
> When building with sensord disabled (PACKAGECONFIG = ""), do_install
> would fail because it tried to build sensord which was skiped in

small typo: skiped -> skipped

> do_compile.
> Error log:
> make: *** No rule to make target 'rrd.h', needed by 'prog/sensord/rrd.rd'. Stop.
> 
> Avoid building sensord in do_install by explicitly setting PROG_EXTRA.
> 
> (master rev: fc88c96c4e40d9dbc6097c4679ac79ed55356730)
> 
> Fixes: 86b20b84ec27 (lmsensors: Clean stale files for sensord to avoid
> incorrect GCC header dependencies)
> 
> Signed-off-by: Leonard Anderweit <l.anderweit@phytec.de>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Otherwise this fixes the build issue
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> ---
>  meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> index e3186132c76c..6e4cf29f479f 100644
> --- a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> +++ b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> @@ -48,7 +48,8 @@ S = "${WORKDIR}/git"
>  EXTRA_OEMAKE = 'EXLDFLAGS="${LDFLAGS}" \
>          MACHINE=${TARGET_ARCH} PREFIX=${prefix} MANDIR=${mandir} \
>          LIBDIR=${libdir} \
> -        CC="${CC}" AR="${AR}"'
> +        CC="${CC}" AR="${AR}" \
> +        PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"'
>  
>  do_configure:prepend() {
>      sed -i -e 's:^#\(PROG_EXTRA\):\1:' ${S}/Makefile
> @@ -59,7 +60,7 @@ do_compile() {
>      sed -i -e 's/\$(LIBDIR)$/\$(LIBDIR) \$(LDFLAGS)/g' ${S}/Makefile
>      sed -i -e 's/\$(LIBSHSONAME) -o/$(LIBSHSONAME) \$(LDFLAGS) -o/g' \
>                  ${S}/lib/Module.mk
> -    oe_runmake user PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"
> +    oe_runmake user
>  }
>  
>  do_install() {
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [oe] [meta-oe][scarthgap][PATCH] lmsensors: Fix build without sensord
  2025-05-15 14:52 ` [oe] " Alexander Stein
@ 2025-05-26  6:32   ` Alexander Stein
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2025-05-26  6:32 UTC (permalink / raw)
  To: openembedded-devel; +Cc: upstream, L.Anderweit

Hi,

Am Donnerstag, 15. Mai 2025, 16:52:32 CEST schrieb Alexander Stein:
> Am Montag, 5. Mai 2025, 11:56:20 CEST schrieb Leonard Anderweit via lists.openembedded.org:
> > When building with sensord disabled (PACKAGECONFIG = ""), do_install
> > would fail because it tried to build sensord which was skiped in
> 
> small typo: skiped -> skipped
> 
> > do_compile.
> > Error log:
> > make: *** No rule to make target 'rrd.h', needed by 'prog/sensord/rrd.rd'. Stop.
> > 
> > Avoid building sensord in do_install by explicitly setting PROG_EXTRA.
> > 
> > (master rev: fc88c96c4e40d9dbc6097c4679ac79ed55356730)
> > 
> > Fixes: 86b20b84ec27 (lmsensors: Clean stale files for sensord to avoid
> > incorrect GCC header dependencies)
> > 
> > Signed-off-by: Leonard Anderweit <l.anderweit@phytec.de>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> 
> Otherwise this fixes the build issue
> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Any feedback when this will be picked up? lmsensor build without sensord
are still broken.

Best regards,
Alexander

> 
> > ---
> >  meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> > index e3186132c76c..6e4cf29f479f 100644
> > --- a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> > +++ b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> > @@ -48,7 +48,8 @@ S = "${WORKDIR}/git"
> >  EXTRA_OEMAKE = 'EXLDFLAGS="${LDFLAGS}" \
> >          MACHINE=${TARGET_ARCH} PREFIX=${prefix} MANDIR=${mandir} \
> >          LIBDIR=${libdir} \
> > -        CC="${CC}" AR="${AR}"'
> > +        CC="${CC}" AR="${AR}" \
> > +        PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"'
> >  
> >  do_configure:prepend() {
> >      sed -i -e 's:^#\(PROG_EXTRA\):\1:' ${S}/Makefile
> > @@ -59,7 +60,7 @@ do_compile() {
> >      sed -i -e 's/\$(LIBDIR)$/\$(LIBDIR) \$(LDFLAGS)/g' ${S}/Makefile
> >      sed -i -e 's/\$(LIBSHSONAME) -o/$(LIBSHSONAME) \$(LDFLAGS) -o/g' \
> >                  ${S}/lib/Module.mk
> > -    oe_runmake user PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"
> > +    oe_runmake user
> >  }
> >  
> >  do_install() {
> > 
> 
> 
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-26  6:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-05  9:56 [meta-oe][scarthgap][PATCH] lmsensors: Fix build without sensord Leonard Anderweit
2025-05-15 14:52 ` [oe] " Alexander Stein
2025-05-26  6:32   ` Alexander Stein

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.