From: Li Wei <lw@cn.fujitsu.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ipv6: fix incorrect route 'expires' value passed to userspace.
Date: Tue, 17 Jul 2012 09:53:35 +0800 [thread overview]
Message-ID: <5004C59F.50702@cn.fujitsu.com> (raw)
In-Reply-To: <20120716094124.0040561f@s6510.linuxnetplumber.net>
于 2012-7-17 0:41, Stephen Hemminger 写道:
> On Mon, 16 Jul 2012 16:09:37 +0800
> Li Wei <lw@cn.fujitsu.com> wrote:
>
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>> index becb048..a7fec9d 100644
>> --- a/net/ipv6/route.c
>> +++ b/net/ipv6/route.c
>> @@ -2516,7 +2516,7 @@ static int rt6_fill_node(struct net *net,
>> goto nla_put_failure;
>> if (!(rt->rt6i_flags & RTF_EXPIRES))
>> expires = 0;
>> - else if (rt->dst.expires - jiffies < INT_MAX)
>> + else if ((int)(rt->dst.expires - jiffies) < INT_MAX)
>> expires = rt->dst.expires - jiffies;
>> else
>> expires = INT_MAX;
>
> Why not use time_is_after_jiffies() macro?
time_is_after_jiffies() return a bool but we need "how much time
before/after jiffies" here.
>
>
However, I also think these code seems a little ugly, because we
need to store the result of two "unsigned long"'s subtraction into
an integer. Maybe we should distinguish expires before and after
jiffies to proper process the overflows.
Thanks,
Wei
next prev parent reply other threads:[~2012-07-17 1:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 8:09 [PATCH] ipv6: fix incorrect route 'expires' value passed to userspace Li Wei
2012-07-16 9:56 ` David Miller
2012-07-17 1:55 ` Li Wei
2012-07-19 2:02 ` [PATCH V2] " Li Wei
2012-07-19 17:49 ` David Miller
2012-07-20 1:32 ` Li Wei
2012-07-20 1:42 ` [PATCH V2 resend] " Li Wei
2012-07-20 10:32 ` David Laight
2012-07-20 18:22 ` David Miller
2012-07-23 1:05 ` Li Wei
2012-07-25 5:25 ` [PATCH V3] " Li Wei
2012-07-25 6:51 ` Eric Dumazet
2012-07-25 7:33 ` Li Wei
2012-07-30 2:01 ` [PATCH v4] " Li Wei
2012-07-30 6:20 ` David Miller
2012-07-23 1:02 ` [PATCH V2 resend] " Li Wei
2012-07-16 16:41 ` [PATCH] " Stephen Hemminger
2012-07-17 1:53 ` Li Wei [this message]
2012-07-17 5:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5004C59F.50702@cn.fujitsu.com \
--to=lw@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.