From: Li Wei <lw@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: David.Laight@ACULAB.COM, netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH V2 resend] ipv6: fix incorrect route 'expires' value passed to userspace
Date: Mon, 23 Jul 2012 09:05:05 +0800 [thread overview]
Message-ID: <500CA341.3070901@cn.fujitsu.com> (raw)
In-Reply-To: <20120720.112241.2111041227435292899.davem@davemloft.net>
On 07/21/2012 02:22 AM, David Miller wrote:
> From: "David Laight" <David.Laight@ACULAB.COM>
> Date: Fri, 20 Jul 2012 11:32:05 +0100
>
>>> - else if (rt->dst.expires - jiffies < INT_MAX)
>>> - expires = rt->dst.expires - jiffies;
>>> + else if ((long)rt->dst.expires - (long)jiffies > INT_MIN
>>> + && (long)rt->dst.expires - (long)jiffies <
>> INT_MAX)
>>> + expires = (long)rt->dst.expires - (long)jiffies;
>>> else
>>> - expires = INT_MAX;
>>> + expires = time_is_after_jiffies(rt->dst.expires) ?
>> INT_MAX : INT_MIN;
>>
>> I can't help feeling there is a better way to do this.
>> Maybe:
>> long expires = rt->dst.expires - jiffies;
>> if (expires != (int)expires)
>> expires = expires > 0 ? INT_MAX : INT_MIN;
>> Although maybe -INT_MAX instead of INT_MIN.
>
> This patch also does not apply at all to net-next, so needs to be
> redone regardless.
I'll redone this patch base on 'net-next'.
Thanks
>
>
next prev parent reply other threads:[~2012-07-23 1:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 8:09 [PATCH] ipv6: fix incorrect route 'expires' value passed to userspace Li Wei
2012-07-16 9:56 ` David Miller
2012-07-17 1:55 ` Li Wei
2012-07-19 2:02 ` [PATCH V2] " Li Wei
2012-07-19 17:49 ` David Miller
2012-07-20 1:32 ` Li Wei
2012-07-20 1:42 ` [PATCH V2 resend] " Li Wei
2012-07-20 10:32 ` David Laight
2012-07-20 18:22 ` David Miller
2012-07-23 1:05 ` Li Wei [this message]
2012-07-25 5:25 ` [PATCH V3] " Li Wei
2012-07-25 6:51 ` Eric Dumazet
2012-07-25 7:33 ` Li Wei
2012-07-30 2:01 ` [PATCH v4] " Li Wei
2012-07-30 6:20 ` David Miller
2012-07-23 1:02 ` [PATCH V2 resend] " Li Wei
2012-07-16 16:41 ` [PATCH] " Stephen Hemminger
2012-07-17 1:53 ` Li Wei
2012-07-17 5:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500CA341.3070901@cn.fujitsu.com \
--to=lw@cn.fujitsu.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.