From: Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Dave Chinner <dchinner@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/8] fsfreeze: Prevent emergency thaw from looping infinitely
Date: Tue, 17 Jul 2012 14:13:53 +0900 [thread overview]
Message-ID: <5004F491.5010207@lab.ntt.co.jp> (raw)
In-Reply-To: <20120713125924.GD20361@quack.suse.cz>
Hi Jan, Dave,
(2012/07/13 21:59), Jan Kara wrote:
> On Thu 12-07-12 18:02:07, Fernando Luis Vázquez Cao wrote:
>> The thawing of a filesystem through sysrq-j loops infinitely as it
>> incorrectly detects a thawed filesytsem as frozen and tries to
>> unfreeze repeatedly. This is a regression caused by
>> 4504230a71566785a05d3e6b53fa1ee071b864eb ("freeze_bdev: grab active
>> reference to frozen superblocks") in that it no longer returned
>> -EINVAL for superblocks that were not frozen.
>>
>> Return -EINVAL when the filesystem is already unfrozen to avoid this
>> problem.
>>
>> Cc: Christoph Hellwig <hch@infradead.org>
>> Cc: Jan Kara <jack@suse.cz>
>> Signed-off-by: Dave Chinner <dchinner@redhat.com>
>> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> Looks good. You can add:
> Reviewed-by: Jan Kara <jack@suse.cz>
Jan, thank you for the detailed review of the patch set. I really appreciate it.
This week I am pretty busy with other stuff so I may not be able to address your
comments and Dave's until next Monday.
Regards,
Fernando
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-17 5:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 8:57 [PATCH 0/8 v2] fsfreeze: miscellaneous fixes and cleanups Fernando Luis Vázquez Cao
2012-07-12 9:02 ` [PATCH 1/8] fsfreeze: Prevent emergency thaw from looping infinitely Fernando Luis Vázquez Cao
2012-07-13 12:59 ` Jan Kara
2012-07-17 5:13 ` Fernando Luis Vazquez Cao [this message]
2012-07-12 9:04 ` [PATCH 2/8] fsfreeze: emergency thaw will deadlock on s_umount Fernando Luis Vázquez Cao
2012-07-13 13:17 ` Jan Kara
2012-08-09 6:00 ` Fernando Luis Vazquez Cao
2012-09-13 6:23 ` Fernando Luis Vazquez Cao
2012-07-12 9:05 ` [PATCH 3/8] fsfreeze: freeze_super and thaw_bdev don't play well together Fernando Luis Vázquez Cao
2012-07-13 13:45 ` Jan Kara
2012-08-09 9:00 ` Fernando Luis Vazquez Cao
2012-07-12 9:07 ` [PATCH 4/8] fsfreeze: switch to using super methods where possible Fernando Luis Vázquez Cao
2012-07-13 13:50 ` Jan Kara
2012-07-12 9:09 ` [PATCH 5/8] fsfreeze: move emergency thaw code to fs/super.c Fernando Luis Vázquez Cao
2012-07-13 13:53 ` Jan Kara
2012-07-12 9:10 ` [PATCH 6/8] fsfreeze: add vfs ioctl to check freeze state Fernando Luis Vázquez Cao
2012-07-13 13:54 ` Jan Kara
2012-07-15 22:45 ` Dave Chinner
2012-09-13 6:19 ` Fernando Luis Vazquez Cao
2012-09-13 7:18 ` Dave Chinner
2012-09-13 8:19 ` Fernando Luis Vazquez Cao
2012-09-14 0:15 ` Dave Chinner
2012-09-14 1:46 ` Fernando Luis Vazquez Cao
2012-09-14 6:28 ` Dave Chinner
2012-09-14 8:18 ` Fernando Luis Vazquez Cao
2012-09-13 6:11 ` Fernando Luis Vazquez Cao
2012-07-12 9:11 ` [PATCH 7/8] fsfreeze: add block device " Fernando Luis Vázquez Cao
2012-07-12 9:12 ` [PATCH 8/8] fsfreeze: update Documentation/filesystems/Locking Fernando Luis Vázquez Cao
2012-07-13 14:11 ` Jan Kara
2012-07-17 1:42 ` Fernando Luis Vazquez Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5004F491.5010207@lab.ntt.co.jp \
--to=fernando_b1@lab.ntt.co.jp \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.