Re: [Xenomai] RTDM driver for the Advantech 1680U CANbus Adapter

[Wolfgang Grandegger <wg@grandegger.com>]

Hi Thierry,

thanks for your cleanup...

On 07/16/2012 05:07 PM, Thierry Bultel wrote:
> Hi Wolfgang,
> 
> How are you ?
> 
> I have taken some time, to take (almost) all your remarks into account
> about my candidate patch.
> Please see below, the new version, inline.

Unfortunately, the patch is white space mangled. Please use
git-send-email or tune your mail client not to break lines, etc.

> - code style / checkpatch : all ERRORs fixed, it remains a spurious "80
> lines" WARNING that I do not agree with.

I think the preferred coding style for Xenomai nowadays is the Linux
one. Therefore please use *tabs*" for indention (even if old RTCAN code
doesn't). This should also make checkpatch.pl even more happier.

> - multiple devices: The driver now (theoretically) supports as many
> devices as its original linux version

Could you mention them in the Kconfig help? Just in case you know the
names of these devices.

> - plx highjack: fixed, this was a bug, actually.
> 
> The patch is generated vs xenomai-2.6.0, because it is my testing
> environnement. I will unfortunately and
> unlikely not have time to perform some tests with a more recent version.
> I hope this is not a blocking issue and that you will be able to
> integrate it anyway.

Should not be a real problem.

> Another topic, please, I would like to know if you have an estimate date
> for the availability of the RTDM
> drivers for Flexcan, and the IMX6 serial as well ?

As you might have realized, there is some interest on a RTCAN Flexcan
driver, which I'm currently working on. Hope to have something ready
this or next week. The same for publishing my rt_imx_uart driver.

Wolfgang.