From: Chris Ferron <chris.e.ferron at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Fix out-of-tree builds
Date: Tue, 17 Jul 2012 15:07:14 -0700 [thread overview]
Message-ID: <5005E212.1050306@linux.intel.com> (raw)
In-Reply-To: 1342126710-26497-1-git-send-email-sw@weilnetz.de
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
On 07/12/2012 01:58 PM, Stefan Weil wrote:
> Out-of-tree builds are a very useful feature which should be supported
> by all programs which use GNU automake and the configure / make build.
>
> For powertop, only a very small fix was needed to make it work.
> Without that fix, powertop.css is not found when a build is not
> started from the source tree, so csstoh fails and creates no css.h.
>
> Signed-off-by: Stefan Weil <sw(a)weilnetz.de>
> ---
> src/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index c77b2aa..23625a2 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -45,5 +45,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
> BUILT_SOURCES = css.h
> CLEANFILES = css.h
> css.h: csstoh powertop.css
> - ./csstoh powertop.css css.h
> + ./csstoh "$(srcdir)"/powertop.css css.h
>
Your patch has been merged.
Thank you,
next reply other threads:[~2012-07-17 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 22:07 Chris Ferron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-12 20:58 [Powertop] [PATCH] Fix out-of-tree builds Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005E212.1050306@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.