Re: [Powertop] [PATCH] Fix out-of-tree builds

Re: [Powertop] [PATCH] Fix out-of-tree builds

[Chris Ferron]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On 07/12/2012 01:58 PM, Stefan Weil wrote:
> Out-of-tree builds are a very useful feature which should be supported
> by all programs which use GNU automake and the configure / make build.
>
> For powertop, only a very small fix was needed to make it work.
> Without that fix, powertop.css is not found when a build is not
> started from the source tree, so csstoh fails and creates no css.h.
>
> Signed-off-by: Stefan Weil <sw(a)weilnetz.de>
> ---
>   src/Makefile.am |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index c77b2aa..23625a2 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -45,5 +45,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
>   BUILT_SOURCES = css.h
>   CLEANFILES = css.h
>   css.h: csstoh powertop.css
> -	./csstoh powertop.css css.h
> +	./csstoh "$(srcdir)"/powertop.css css.h
>   
Your patch has been merged.
Thank you,

[Powertop] [PATCH] Fix out-of-tree builds

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Out-of-tree builds are a very useful feature which should be supported
by all programs which use GNU automake and the configure / make build.

For powertop, only a very small fix was needed to make it work.
Without that fix, powertop.css is not found when a build is not
started from the source tree, so csstoh fails and creates no css.h.

Signed-off-by: Stefan Weil <sw(a)weilnetz.de>
---
 src/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index c77b2aa..23625a2 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -45,5 +45,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
 BUILT_SOURCES = css.h
 CLEANFILES = css.h
 css.h: csstoh powertop.css
-	./csstoh powertop.css css.h
+	./csstoh "$(srcdir)"/powertop.css css.h
 
-- 
1.7.10