[Powertop] [PATCH] ccstoh: Don't return success if something went wrong

[Powertop] [PATCH] ccstoh: Don't return success if something went wrong

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

exit(0) is the same as returning EXIT_SUCCESS which is a bad
idea after a severe failure. It will for example result in
wrong behaviour of make (make won't stop after such failures).

Returning EXIT_FAILURE fixes this.

Signed-off-by: Stefan Weil <sw(a)weilnetz.de>
---
 src/csstoh.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/csstoh.c b/src/csstoh.c
index e6b1dcf..28858f5 100644
--- a/src/csstoh.c
+++ b/src/csstoh.c
@@ -40,12 +40,12 @@ int main(int argc, char **argv)
 	in = fopen(argv[1], "rm");
 	if (!in) {
 		printf("Failed to open input file %s (%s) \n", argv[1], strerror(errno));
-		exit(0);
+		return EXIT_FAILURE;
 	}
 	out = fopen(argv[2], "wm");
 	if (!out) {
 		printf("Failed to open output file %s (%s) \n", argv[1], strerror(errno));
-		exit(0);
+		return EXIT_FAILURE;
 	}
 
 	fprintf(out, "#ifndef __INCLUDE_GUARD_CCS_H\n");
-- 
1.7.10

Re: [Powertop] [PATCH] ccstoh: Don't return success if something went wrong

[Chris Ferron]

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

On 07/12/2012 01:41 PM, Stefan Weil wrote:
> exit(0) is the same as returning EXIT_SUCCESS which is a bad
> idea after a severe failure. It will for example result in
> wrong behaviour of make (make won't stop after such failures).
>
> Returning EXIT_FAILURE fixes this.
>
> Signed-off-by: Stefan Weil <sw(a)weilnetz.de>
> ---
>   src/csstoh.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/csstoh.c b/src/csstoh.c
> index e6b1dcf..28858f5 100644
> --- a/src/csstoh.c
> +++ b/src/csstoh.c
> @@ -40,12 +40,12 @@ int main(int argc, char **argv)
>   	in = fopen(argv[1], "rm");
>   	if (!in) {
>   		printf("Failed to open input file %s (%s) \n", argv[1], strerror(errno));
> -		exit(0);
> +		return EXIT_FAILURE;
>   	}
>   	out = fopen(argv[2], "wm");
>   	if (!out) {
>   		printf("Failed to open output file %s (%s) \n", argv[1], strerror(errno));
> -		exit(0);
> +		return EXIT_FAILURE;
>   	}
>   
>   	fprintf(out, "#ifndef __INCLUDE_GUARD_CCS_H\n");
Your patch has been merged.
Thank you,