From: John Fastabend <john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: mark.d.rustad-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: That's pretty much it for 3.5.0
Date: Tue, 17 Jul 2012 16:27:53 -0700 [thread overview]
Message-ID: <5005F4F9.6010208@intel.com> (raw)
In-Reply-To: <20120717.151832.1306978935355646723.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On 7/17/2012 3:18 PM, David Miller wrote:
> From: John Fastabend <john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Tue, 17 Jul 2012 15:13:36 -0700
>
>> Perhaps the easiest way is to check net->count this should be zero
>> until setup_net is called.
>>
>> if (!atomic_read(&init_net.count))
>> return ret;
>>
>
> Won't work, setup_net() runs via a pure_initcall().
>
Why not must have missed something? cgroup_init() and
cgroup_early_init() both run before _initcall() routines are
called via kernel_init() so this will stop the update in
netprio from occurring.
And I don't see any race elsewhere for this.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: John Fastabend <john.r.fastabend@intel.com>
To: David Miller <davem@davemloft.net>
Cc: mark.d.rustad@intel.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: That's pretty much it for 3.5.0
Date: Tue, 17 Jul 2012 16:27:53 -0700 [thread overview]
Message-ID: <5005F4F9.6010208@intel.com> (raw)
In-Reply-To: <20120717.151832.1306978935355646723.davem@davemloft.net>
On 7/17/2012 3:18 PM, David Miller wrote:
> From: John Fastabend <john.r.fastabend@intel.com>
> Date: Tue, 17 Jul 2012 15:13:36 -0700
>
>> Perhaps the easiest way is to check net->count this should be zero
>> until setup_net is called.
>>
>> if (!atomic_read(&init_net.count))
>> return ret;
>>
>
> Won't work, setup_net() runs via a pure_initcall().
>
Why not must have missed something? cgroup_init() and
cgroup_early_init() both run before _initcall() routines are
called via kernel_init() so this will stop the update in
netprio from occurring.
And I don't see any race elsewhere for this.
next prev parent reply other threads:[~2012-07-17 23:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 16:01 That's pretty much it for 3.5.0 David Miller
2012-07-17 17:41 ` Rustad, Mark D
2012-07-17 18:48 ` Rustad, Mark D
2012-07-17 19:00 ` John Fastabend
2012-07-17 19:09 ` John Fastabend
[not found] ` <5005B881.8010505-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-07-17 19:17 ` John Fastabend
2012-07-17 19:17 ` John Fastabend
2012-07-17 19:26 ` John Fastabend
2012-07-17 19:24 ` David Miller
2012-07-17 20:50 ` John Fastabend
2012-07-17 21:02 ` David Miller
2012-07-17 22:13 ` John Fastabend
2012-07-17 22:18 ` David Miller
[not found] ` <20120717.151832.1306978935355646723.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-07-17 23:27 ` John Fastabend [this message]
2012-07-17 23:27 ` John Fastabend
2012-07-18 13:04 ` Neil Horman
2012-07-18 17:36 ` Rustad, Mark D
2012-07-18 17:55 ` Eric Dumazet
2012-07-18 18:31 ` Rustad, Mark D
2012-07-18 18:31 ` Rustad, Mark D
[not found] ` <FEB6B45E-1CCF-4CBC-AEB7-21D2088E175C-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-07-18 18:33 ` David Miller
2012-07-18 18:33 ` David Miller
2012-07-17 19:30 ` wireless.git frozen -- " John W. Linville
2012-07-17 19:30 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005F4F9.6010208@intel.com \
--to=john.r.fastabend-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.d.rustad-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.