diff for duplicates of <5008ACF7.6000009@renesas.com> diff --git a/a/1.txt b/N1/1.txt index 6e53f48..8ec5bcd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,11 @@ Hi, Phil. -phil.edworthy-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org さんは書きました: +phil.edworthy@renesas.com さんは書きました: > Hi Iwamatsu-san, > >> Date: 16/04/2012 01:58 >> Subject: Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller ->> Sent by: linux-sh-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +>> Sent by: linux-sh-owner@vger.kernel.org >> >> Kuninori Morimoto さんは書きました: >>> Hi Iwamatsu-san @@ -28,15 +28,15 @@ phil.edworthy-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org さんは書きました: > > The following code is not suitable for sh7269: > + /* Mask clear interrupts */ -> + if (pd->adap.nr == 0) +> + if (pd->adap.nr = 0) > + __raw_writel(I2C_INT_ALL, I2C0_INTMASK_CLR); -> + else if (pd->adap.nr == 1) +> + else if (pd->adap.nr = 1) > + __raw_writel(I2C_INT_ALL, I2C1_INTMASK_CLR); > > + /* Mask interrupts */ -> + if (pd->adap.nr == 0) +> + if (pd->adap.nr = 0) > + __raw_writel(I2C_INT_ALL, I2C0_INTMASK); -> + else if (pd->adap.nr == 1) +> + else if (pd->adap.nr = 1) > + __raw_writel(I2C_INT_ALL, I2C1_INTMASK); > > Do you plan to send this driver again? If yes, maybe add #ifdef CPU_SUBTYPE_SH7734 around this code, or add platform data to enable it. diff --git a/a/content_digest b/N1/content_digest index 0b5a859..41fd64d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,9 +7,9 @@ "ref\04F8B7019.2030307@renesas.com\0" "ref\0OF7FE4858F.5425E857-ON80257A3F.002C2DA0-80257A3F.002E3111@eu.necel.com\0" "ref\0OF7FE4858F.5425E857-ON80257A3F.002C2DA0-80257A3F.002E3111-mWMTcI9IYFFWk0Htik3J/w@public.gmane.org\0" - "From\0Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>\0" + "From\0Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>\0" "Subject\0Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller\0" - "Date\0Fri, 20 Jul 2012 09:57:27 +0900\0" + "Date\0Fri, 20 Jul 2012 00:57:27 +0000\0" "To\0phil.edworthy-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org\0" "Cc\0Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>" Linux-I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> @@ -20,12 +20,12 @@ "b\0" "Hi, Phil.\n" "\n" - "phil.edworthy-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \343\201\225\343\202\223\343\201\257\346\233\270\343\201\215\343\201\276\343\201\227\343\201\237:\n" + "phil.edworthy@renesas.com \343\201\225\343\202\223\343\201\257\346\233\270\343\201\215\343\201\276\343\201\227\343\201\237:\n" "> Hi Iwamatsu-san,\n" "> \n" ">> Date: 16/04/2012 01:58\n" ">> Subject: Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller\n" - ">> Sent by: linux-sh-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + ">> Sent by: linux-sh-owner@vger.kernel.org\n" ">>\n" ">> Kuninori Morimoto \343\201\225\343\202\223\343\201\257\346\233\270\343\201\215\343\201\276\343\201\227\343\201\237:\n" ">>> Hi Iwamatsu-san\n" @@ -48,15 +48,15 @@ "> \n" "> The following code is not suitable for sh7269:\n" "> +\t/* Mask clear interrupts */\n" - "> +\tif (pd->adap.nr == 0)\n" + "> +\tif (pd->adap.nr = 0)\n" "> +\t\t__raw_writel(I2C_INT_ALL, I2C0_INTMASK_CLR);\n" - "> +\telse if (pd->adap.nr == 1)\n" + "> +\telse if (pd->adap.nr = 1)\n" "> +\t\t__raw_writel(I2C_INT_ALL, I2C1_INTMASK_CLR);\n" "> \n" "> +\t/* Mask interrupts */\n" - "> +\tif (pd->adap.nr == 0)\n" + "> +\tif (pd->adap.nr = 0)\n" "> +\t\t__raw_writel(I2C_INT_ALL, I2C0_INTMASK);\n" - "> +\telse if (pd->adap.nr == 1)\n" + "> +\telse if (pd->adap.nr = 1)\n" "> +\t\t__raw_writel(I2C_INT_ALL, I2C1_INTMASK);\n" "> \n" "> Do you plan to send this driver again? If yes, maybe add #ifdef CPU_SUBTYPE_SH7734 around this code, or add platform data to enable it.\n" @@ -66,4 +66,4 @@ "Best regards,\n" Nobuhiro -a410b5bd55742eb8c865a51e343be19a7aab886988a9a703c2143b45bc19877a +6ac7a8c7a4721ccf4a1cf7806f9186252df13b77ec11c4d6ccd27d59403160d2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.