Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller

[Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]

Hi, Phil.

phil.edworthy-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org さんは書きました:
> Hi Iwamatsu-san,
> 
>> Date: 16/04/2012 01:58
>> Subject: Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller
>> Sent by: linux-sh-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>
>> Kuninori Morimoto さんは書きました:
>>> Hi Iwamatsu-san
>>>
>>>>> I guess R-Car is not same as this I2C.
>>>>> And sorry, SH7734 seems not same as SH-NAVI.
>>>>> Now I'm checking the series.
>>>>> Please wait.
>>>>>
>>>> I already checked SH7775 and SH7776. These are SH-NAVI series.
>>>> But these CPU's are constitution unlike I2C of SH7734.
>>> I got the information about it this morning.
>>> SH7734 I2C came from SH7266, and it came from SH-NaviJ3.
>>>
>> I comfirmed these, thanks.
>> OK, I will rename file and update description.
> 
> I noticed your sh7734 i2c patch and realised that the registers are the same as sh7269 (sh2a). I tried this driver on sh7269, but I had to make some
> changes to use it.
> 
> The following code is not suitable for sh7269:
> +	/* Mask clear interrupts */
> +	if (pd->adap.nr == 0)
> +		__raw_writel(I2C_INT_ALL, I2C0_INTMASK_CLR);
> +	else if (pd->adap.nr == 1)
> +		__raw_writel(I2C_INT_ALL, I2C1_INTMASK_CLR);
> 
> +	/* Mask interrupts */
> +	if (pd->adap.nr == 0)
> +		__raw_writel(I2C_INT_ALL, I2C0_INTMASK);
> +	else if (pd->adap.nr == 1)
> +		__raw_writel(I2C_INT_ALL, I2C1_INTMASK);
> 
> Do you plan to send this driver again? If yes, maybe add #ifdef CPU_SUBTYPE_SH7734 around this code, or add platform data to enable it.

I will resend patch with some fixes and your point.

Best regards,
  Nobuhiro