From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Robert Jennings <rcj@linux.vnet.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kent Yoder <key@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver
Date: Fri, 20 Jul 2012 09:01:11 -0500 [thread overview]
Message-ID: <500964A7.1020702@linux.vnet.ibm.com> (raw)
In-Reply-To: <1342762410.15356.7.camel@concordia>
On 07/20/2012 12:33 AM, Michael Ellerman wrote:
> On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote:
>> This patch adds the driver for interacting with the 842
>> compression accelerator on IBM Power7+ systems.
>
> ...
>
>> +struct nx842_slentry {
>> + unsigned long ptr; /* Absolute address (use virt_to_abs()) */
>> /+ unsigned long len;
>> +};
>
> These days virt_to_abs() is just __pa() - ie. convert to a real address.
Thanks, I'll make that change.
Is it a blocker to the code being pulled in though? I'm
hoping to get this in ASAP for the 3.6 merge window. As
this isn't a functional defect (I assume __pa() and
virt_to_abs() still achieve the same result), can I get an
OK from you that this isn't a blocker to the code being
accepted?
I'll submit a patch later to make this change.
Thanks again!
Seth
WARNING: multiple messages have this Message-ID (diff)
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kent Yoder <key@linux.vnet.ibm.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver
Date: Fri, 20 Jul 2012 09:01:11 -0500 [thread overview]
Message-ID: <500964A7.1020702@linux.vnet.ibm.com> (raw)
In-Reply-To: <1342762410.15356.7.camel@concordia>
On 07/20/2012 12:33 AM, Michael Ellerman wrote:
> On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote:
>> This patch adds the driver for interacting with the 842
>> compression accelerator on IBM Power7+ systems.
>
> ...
>
>> +struct nx842_slentry {
>> + unsigned long ptr; /* Absolute address (use virt_to_abs()) */
>> /+ unsigned long len;
>> +};
>
> These days virt_to_abs() is just __pa() - ie. convert to a real address.
Thanks, I'll make that change.
Is it a blocker to the code being pulled in though? I'm
hoping to get this in ASAP for the 3.6 merge window. As
this isn't a functional defect (I assume __pa() and
virt_to_abs() still achieve the same result), can I get an
OK from you that this isn't a blocker to the code being
accepted?
I'll submit a patch later to make this change.
Thanks again!
Seth
next prev parent reply other threads:[~2012-07-20 14:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 14:42 [PATCH 0/4] powerpc/crypto: IBM Power7+ in-Nest compression support Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` [PATCH 1/4] powerpc/crypto: rework Kconfig Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` [PATCH 2/4] powerpc/crypto: add compression support to arch vec Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-20 5:33 ` Michael Ellerman
2012-07-20 5:33 ` Michael Ellerman
2012-07-20 5:33 ` Michael Ellerman
2012-07-20 14:01 ` Seth Jennings [this message]
2012-07-20 14:01 ` Seth Jennings
2012-07-30 8:00 ` Michael Ellerman
2012-07-30 8:00 ` Michael Ellerman
2012-07-30 8:00 ` Michael Ellerman
2012-07-19 14:42 ` [PATCH 4/4] powerpc/crypto: add 842 crypto driver Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-19 14:42 ` Seth Jennings
2012-07-30 7:56 ` [PATCH 0/4] powerpc/crypto: IBM Power7+ in-Nest compression support Herbert Xu
2012-07-30 7:56 ` Herbert Xu
2012-07-30 7:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500964A7.1020702@linux.vnet.ibm.com \
--to=sjenning@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=key@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.