From: Jiri Slaby <jslaby@suse.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] tty: handle NULL parameters in free_tty_struct()
Date: Fri, 20 Jul 2012 21:32:30 +0000 [thread overview]
Message-ID: <5009CE6E.4080006@suse.cz> (raw)
In-Reply-To: <20120720104831.47cb4237@pyramind.ukuu.org.uk>
On 07/20/2012 11:48 AM, Alan Cox wrote:
> On Fri, 20 Jul 2012 10:06:34 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
>> We sometimes pass NULL pointers to free_tty_struct(). One example where
>> it can happen is in the error handling code in pty_common_install().
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Alan Cox <alan@linux.intel.com>
>
> We probably shouldn't be passing NULLs there but making
> free_tty_struct(NULL) a no-op matches the kfree and other behaviours and
> is robust.
Yes, this was unintended. Good catch, Dan.
thanks,
--
js
suse labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jslaby@suse.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] tty: handle NULL parameters in free_tty_struct()
Date: Fri, 20 Jul 2012 23:32:30 +0200 [thread overview]
Message-ID: <5009CE6E.4080006@suse.cz> (raw)
In-Reply-To: <20120720104831.47cb4237@pyramind.ukuu.org.uk>
On 07/20/2012 11:48 AM, Alan Cox wrote:
> On Fri, 20 Jul 2012 10:06:34 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
>> We sometimes pass NULL pointers to free_tty_struct(). One example where
>> it can happen is in the error handling code in pty_common_install().
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Alan Cox <alan@linux.intel.com>
>
> We probably shouldn't be passing NULLs there but making
> free_tty_struct(NULL) a no-op matches the kfree and other behaviours and
> is robust.
Yes, this was unintended. Good catch, Dan.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-07-20 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 7:06 [patch] tty: handle NULL parameters in free_tty_struct() Dan Carpenter
2012-07-20 7:06 ` Dan Carpenter
2012-07-20 9:48 ` Alan Cox
2012-07-20 9:48 ` Alan Cox
2012-07-20 21:32 ` Jiri Slaby [this message]
2012-07-20 21:32 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5009CE6E.4080006@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.