From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH 4/7] Remove obsolete LONG_USAGE which breaks xgettext
Date: Sat, 21 Jul 2012 18:26:19 +0200 [thread overview]
Message-ID: <500AD82B.9010604@gmail.com> (raw)
In-Reply-To: <941f7bd695e8a14c940a5b8e4214d2773ae82557.1342884459.git.worldhello.net@gmail.com>
On 07/21/2012 05:50 PM, Jiang Xin wrote:
> The obsolete LONG_USAGE variable has the following message in it:
>
> A'\''--B'\''--C'\''
>
> And such complex LONG_USAGE message will breaks xgettext when extract
>
s/extract/extracting/ I think.
> l10n messages. But if remove single quotes from the message,
>
s/remove/we remove/; or, if the passive voice is not a problem, you might
reformulate the sentence as follows:
But if single quotes are removed from the message, ...
> xgettext works fine on 'git-rebase.sh'.
>
> Since there is a mordern
>
s/mordern/modern/
> OPTIONS_SPEC variable in use in this script,
> it's safe to remove the obsolte
>
s/obsolte/obsolete/
> USAGE and LONG_USAGE variables.
>
Regards,
Stefano
next prev parent reply other threads:[~2012-07-21 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 15:50 [PATCH 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-21 15:50 ` [PATCH 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-21 16:20 ` Stefano Lattarini
2012-07-21 15:50 ` [PATCH 2/7] i18n: rebase: mark strings for translation Jiang Xin
2012-07-21 15:50 ` [PATCH 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-21 16:23 ` Stefano Lattarini
2012-07-21 15:50 ` [PATCH 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-21 16:26 ` Stefano Lattarini [this message]
2012-07-21 15:50 ` [PATCH 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-21 16:27 ` Stefano Lattarini
2012-07-21 15:50 ` [PATCH 6/7] Remove unused and bad gettext block from git-am Jiang Xin
2012-07-21 16:29 ` Stefano Lattarini
2012-07-22 1:33 ` Jiang Xin
2012-07-21 15:50 ` [PATCH 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500AD82B.9010604@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.