From: Jaehoon Chung <jh80.chung@samsung.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Thomas Abraham' <thomas.abraham@linaro.org>,
'Jaehoon Chung' <jh80.chung@samsung.com>,
linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, cjb@laptop.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
linux-samsung-soc@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation
Date: Mon, 23 Jul 2012 10:57:35 +0900 [thread overview]
Message-ID: <500CAF8F.5040407@samsung.com> (raw)
In-Reply-To: <195201cd6600$7cb089f0$76119dd0$%kim@samsung.com>
On 07/20/2012 07:47 AM, Kukjin Kim wrote:
> Thomas Abraham wrote:
>>
>> On 19 July 2012 20:58, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> Hi Thomas,
>>>
>>> I think not good that added the samsung specific code into dw_mmc-
>> pltfm.c
>>> How about separating to dw-mmc-exynos.c?
>>
>> I am not sure of this. The only samsung specific code in
>> dw_mmc-pltfm.c file is the data for of_device_id instances. The clock
>> lookup added into this file in the 3rd patch does not cause any harm
>> on non-samsung SoC's which might not define those clocks (on clock
>> lookup failure, there are only warning printed, the driver's probe
>> does not fail.
>>
> I agree with Thomas' opinion, in addition, the dw_mmc-pltfm.c file can
> support that, so adding dw-mmc-exynos.c is not needed now.
>
>> I would prefer not to add separate file for Exynos SoC's for now.
>> Splitting into different files will need to defined new callbacks
>> which I fell is not really required.
Then where is the callback function located?
Best Regards,
Jaehoon Chung
>>
> Yes.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: jh80.chung@samsung.com (Jaehoon Chung)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation
Date: Mon, 23 Jul 2012 10:57:35 +0900 [thread overview]
Message-ID: <500CAF8F.5040407@samsung.com> (raw)
In-Reply-To: <195201cd6600$7cb089f0$76119dd0$%kim@samsung.com>
On 07/20/2012 07:47 AM, Kukjin Kim wrote:
> Thomas Abraham wrote:
>>
>> On 19 July 2012 20:58, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> Hi Thomas,
>>>
>>> I think not good that added the samsung specific code into dw_mmc-
>> pltfm.c
>>> How about separating to dw-mmc-exynos.c?
>>
>> I am not sure of this. The only samsung specific code in
>> dw_mmc-pltfm.c file is the data for of_device_id instances. The clock
>> lookup added into this file in the 3rd patch does not cause any harm
>> on non-samsung SoC's which might not define those clocks (on clock
>> lookup failure, there are only warning printed, the driver's probe
>> does not fail.
>>
> I agree with Thomas' opinion, in addition, the dw_mmc-pltfm.c file can
> support that, so adding dw-mmc-exynos.c is not needed now.
>
>> I would prefer not to add separate file for Exynos SoC's for now.
>> Splitting into different files will need to defined new callbacks
>> which I fell is not really required.
Then where is the callback function located?
Best Regards,
Jaehoon Chung
>>
> Yes.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-07-23 1:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 12:54 [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-12 12:54 ` [PATCH v3 1/6] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
[not found] ` <1342097668-25243-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-07-12 12:54 ` [PATCH v3 2/6] mmc: dw_mmc: allow probe to succeed even if one slot is initialized Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-12 12:54 ` [PATCH v3 3/6] mmc: dw_mmc: lookup for optional biu and ciu clocks Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-13 9:11 ` Girish K S
2012-07-13 9:11 ` Girish K S
2012-07-17 10:38 ` [PATCH 3/9] " Thomas Abraham
2012-07-17 10:38 ` Thomas Abraham
2012-07-19 10:27 ` Seungwon Jeon
2012-07-19 10:27 ` Seungwon Jeon
2012-07-12 12:54 ` [PATCH v3 4/6] mmc: dw_mmc: add quirk to indicate missing write protect line Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-12 12:54 ` [PATCH v3 5/6] mmc: dw_mmc: add device tree support Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-16 4:15 ` Girish K S
2012-07-16 4:15 ` Girish K S
2012-07-16 4:30 ` Girish K S
2012-07-16 4:30 ` Girish K S
2012-07-17 10:19 ` Thomas Abraham
2012-07-17 10:19 ` Thomas Abraham
2012-07-16 4:23 ` Chris Ball
2012-07-16 4:23 ` Chris Ball
[not found] ` <87liikjpw0.fsf-DGHOrqG7t0YzNDMTQreKSUB+6BGkLq7r@public.gmane.org>
2012-07-17 10:21 ` Thomas Abraham
2012-07-17 10:21 ` Thomas Abraham
2012-07-17 10:21 ` Thomas Abraham
2012-07-17 10:37 ` [PATCH 5/9] " Thomas Abraham
2012-07-17 10:37 ` Thomas Abraham
2012-07-12 12:54 ` [PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham
2012-07-19 3:51 ` Seungwon Jeon
2012-07-19 3:51 ` Seungwon Jeon
2012-07-19 18:48 ` Thomas Abraham
2012-07-19 18:48 ` Thomas Abraham
2012-07-20 10:38 ` Seungwon Jeon
2012-07-20 10:38 ` Seungwon Jeon
2012-07-23 6:17 ` Thomas Abraham
2012-07-23 6:17 ` Thomas Abraham
2012-07-23 9:59 ` Seungwon Jeon
2012-07-23 9:59 ` Seungwon Jeon
2012-07-19 15:28 ` [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation Jaehoon Chung
2012-07-19 15:28 ` Jaehoon Chung
2012-07-19 18:59 ` Thomas Abraham
2012-07-19 18:59 ` Thomas Abraham
2012-07-19 22:47 ` Kukjin Kim
2012-07-19 22:47 ` Kukjin Kim
2012-07-23 1:57 ` Jaehoon Chung [this message]
2012-07-23 1:57 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500CAF8F.5040407@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.