All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] mmc: dw-mmc: fixed secstion mismatch in reference
@ 2012-07-24  5:55 Jaehoon Chung
  2012-08-24  3:53 ` Seungwon Jeon
  0 siblings, 1 reply; 2+ messages in thread
From: Jaehoon Chung @ 2012-07-24  5:55 UTC (permalink / raw)
  To: linux-mmc
  Cc: Chris Ball, Kyungmin Park, Will Newton, James Hogan,
	Seungwon Jeon

Fixed the below message.

WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function dw_mci_probe() to the function .init.text:dw_mci_init_slot()
The function dw_mci_probe() references
the function __init dw_mci_init_slot().
This is often because dw_mci_probe lacks a __init
annotation or the annotation of dw_mci_init_slot is wrong

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
Changelog v2:
	- added __init macro to dw_mmc_pltfm_probe.(reviewed by Seungwon)
 drivers/mmc/host/dw_mmc-pltfm.c |    2 +-
 drivers/mmc/host/dw_mmc.c       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c
index 92ec3eb..58ed89b 100644
--- a/drivers/mmc/host/dw_mmc-pltfm.c
+++ b/drivers/mmc/host/dw_mmc-pltfm.c
@@ -21,7 +21,7 @@
 #include <linux/mmc/dw_mmc.h>
 #include "dw_mmc.h"
 
-static int dw_mci_pltfm_probe(struct platform_device *pdev)
+static int __init dw_mci_pltfm_probe(struct platform_device *pdev)
 {
 	struct dw_mci *host;
 	struct resource	*regs;
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 72dc3cd..7955eba 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
 	}
 }
 
-static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
+static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
 {
 	struct mmc_host *mmc;
 	struct dw_mci_slot *slot;
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH v2] mmc: dw-mmc: fixed secstion mismatch in reference
  2012-07-24  5:55 [PATCH v2] mmc: dw-mmc: fixed secstion mismatch in reference Jaehoon Chung
@ 2012-08-24  3:53 ` Seungwon Jeon
  0 siblings, 0 replies; 2+ messages in thread
From: Seungwon Jeon @ 2012-08-24  3:53 UTC (permalink / raw)
  To: 'Jaehoon Chung', 'linux-mmc'
  Cc: 'Chris Ball', 'Kyungmin Park',
	'Will Newton', 'James Hogan'

On July 24, 2012, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Fixed the below message.
> 
> WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function
> dw_mci_probe() to the function .init.text:dw_mci_init_slot()
> The function dw_mci_probe() references
> the function __init dw_mci_init_slot().
> This is often because dw_mci_probe lacks a __init
> annotation or the annotation of dw_mci_init_slot is wrong
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changelog v2:
> 	- added __init macro to dw_mmc_pltfm_probe.(reviewed by Seungwon)
>  drivers/mmc/host/dw_mmc-pltfm.c |    2 +-
>  drivers/mmc/host/dw_mmc.c       |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c
> index 92ec3eb..58ed89b 100644
> --- a/drivers/mmc/host/dw_mmc-pltfm.c
> +++ b/drivers/mmc/host/dw_mmc-pltfm.c
> @@ -21,7 +21,7 @@
>  #include <linux/mmc/dw_mmc.h>
>  #include "dw_mmc.h"
> 
> -static int dw_mci_pltfm_probe(struct platform_device *pdev)
> +static int __init dw_mci_pltfm_probe(struct platform_device *pdev)
>  {
>  	struct dw_mci *host;
>  	struct resource	*regs;
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 72dc3cd..7955eba 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
>  	}
>  }
> 
> -static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> +static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>  {
>  	struct mmc_host *mmc;
>  	struct dw_mci_slot *slot;

Looks good to me.
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>

Thanks,
Seungwon Jeon

> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-24  3:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24  5:55 [PATCH v2] mmc: dw-mmc: fixed secstion mismatch in reference Jaehoon Chung
2012-08-24  3:53 ` Seungwon Jeon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.