From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] io.h clean-up for PCI
Date: Tue, 24 Jul 2012 08:25:37 -0500 [thread overview]
Message-ID: <500EA251.1090000@gmail.com> (raw)
In-Reply-To: <201207241243.55640.arnd@arndb.de>
On 07/24/2012 07:43 AM, Arnd Bergmann wrote:
> On Tuesday 24 July 2012, Rob Herring wrote:
>>> --- a/arch/arm/mach-iop13xx/include/mach/iop13xx.h
>>> +++ b/arch/arm/mach-iop13xx/include/mach/iop13xx.h
>>> @@ -95,7 +95,6 @@ extern unsigned long get_iop_tick_rate(void);
>>> /* PCI-E ranges */
>>> #define IOP13XX_PCIE_LOWER_IO_PA 0xfffd0000UL
>>> #define IOP13XX_PCIE_LOWER_IO_BA 0x0UL /* OIOTVR */
>>> -#define IOP13XX_PCIE_LOWER_IO_BA 0x10000UL
>>
>> This means we have PCIE and PCIX buses both using i/o bus addresses
>> starting at 0x0. We can't have that, right?
>>
>> The requested resource won't match either as the resource start address
>> is bus_nr * 64K.
>
> Well, this is the number that gets written into the outbound
> translation window register, which has to be zero AFAICT.
>
> The PCI device you plug into the bus will always see its io
> ports as being between zero and 65536 -- the part that
> stays at 0x10000UL is the offset address that we use in Linux
> to give it a unique address in the virtual address space
> window we use to cover all the io port ranges.
>
> The io_offset still gets set to 0x10000, so this number always
> gets added and subtracted when converting between Linux port
> numbers and bus-specific port numbers.
Okay, then this is probably something I need to fix.
How is mem_offset supposed to be set? Generally memory is setup as cpu
base paddr = pci mem addr, so mem_offset should be 0? But integrator is
set to the cpu paddr, and it works.
Rob
>
> Arnd
>
next prev parent reply other threads:[~2012-07-24 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 22:15 [GIT PULL] io.h clean-up for PCI Rob Herring
2012-07-17 20:53 ` Arnd Bergmann
2012-07-19 14:12 ` Arnd Bergmann
2012-07-24 12:33 ` Rob Herring
2012-07-24 12:43 ` Arnd Bergmann
2012-07-24 13:25 ` Rob Herring [this message]
2012-07-24 14:18 ` Arnd Bergmann
2012-07-25 14:41 ` Rob Herring
2012-07-25 15:52 ` Arnd Bergmann
2012-07-19 14:16 ` Arnd Bergmann
2012-07-23 0:35 ` Rob Herring
2012-07-27 21:59 ` Rob Herring
2012-07-28 14:38 ` Will Deacon
2012-07-30 11:05 ` Rob Herring
2012-07-30 14:31 ` Russell King - ARM Linux
2012-07-30 14:56 ` Rob Herring
2012-08-27 8:27 ` Russell King - ARM Linux
2012-08-28 0:14 ` Rob Herring
2012-07-29 23:07 ` Olof Johansson
2012-08-14 9:14 ` Will Deacon
2012-08-14 9:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500EA251.1090000@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.