From: Timur Tabi <timur@freescale.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@ti.com, Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH 1/2] ALSA: ASoC: add DT bindings for cs4270
Date: Tue, 24 Jul 2012 17:03:35 -0500 [thread overview]
Message-ID: <500F1BB7.7020504@freescale.com> (raw)
In-Reply-To: <500F1B05.3050107@wwwdotorg.org>
Stephen Warren wrote:
> The I2C code matches the compatible values from the device tree against
> two tables in the kernel. First, the of_match_table that this patch
> adds, and then if there's no match it falls back to the I2C device ID
> table, and matches that against the DT compatible value with the vendor
> prefix stripped off.
>
> So while the second method does work as a fall-back, in the past I've
> received guidance (I think from Grant Likely) that we should still add
> the of_match_table to drivers in order to be explicit.
So you're saying that all I2C device drivers should have an
of_match_table()? If so, then we should probably fix all codec drivers in
one patch.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-07-24 22:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 20:20 [PATCH 1/2] ALSA: ASoC: add DT bindings for cs4270 Daniel Mack
2012-07-24 20:20 ` [PATCH 2/2] ALSA: ASoC: Add reset-gpio DT property to cs4270 driver Daniel Mack
2012-07-24 20:22 ` [PATCH 1/2] ALSA: ASoC: add DT bindings for cs4270 Timur Tabi
2012-07-24 20:26 ` Daniel Mack
2012-07-24 20:30 ` Timur Tabi
2012-07-24 20:32 ` Daniel Mack
2012-07-24 20:39 ` Timur Tabi
2012-07-24 20:53 ` Daniel Mack
2012-07-24 21:01 ` Timur Tabi
2012-07-25 6:19 ` Daniel Mack
2012-07-24 22:01 ` Stephen Warren
2012-07-24 22:02 ` Timur Tabi
2012-07-24 22:42 ` Mark Brown
2012-07-24 22:41 ` Mark Brown
2012-07-24 22:00 ` Stephen Warren
2012-07-24 22:03 ` Timur Tabi [this message]
2012-07-24 22:44 ` Mark Brown
2012-07-25 6:12 ` Daniel Mack
2012-07-25 7:03 ` [PATCH 2/2 v2] ALSA: ASoC: Add reset-gpio DT property to cs4270 driver Daniel Mack
2012-07-25 13:18 ` Mark Brown
2012-07-25 13:22 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500F1BB7.7020504@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.