Re: [PATCH 1/2] ALSA: ASoC: add DT bindings for cs4270

[Daniel Mack <zonque@gmail.com>]

On 25.07.2012 00:44, Mark Brown wrote:
> On Tue, Jul 24, 2012 at 05:03:35PM -0500, Timur Tabi wrote:
>> Stephen Warren wrote:
>>> The I2C code matches the compatible values from the device tree against
>>> two tables in the kernel. First, the of_match_table that this patch
>>> adds, and then if there's no match it falls back to the I2C device ID
>>> table, and matches that against the DT compatible value with the vendor
>>> prefix stripped off.
> 
>>> So while the second method does work as a fall-back, in the past I've
>>> received guidance (I think from Grant Likely) that we should still add
>>> the of_match_table to drivers in order to be explicit.
> 
>> So you're saying that all I2C device drivers should have an
> 
> It's certainly better to add one, it avoids any ambiguity in part
> numbers (there's at least one other chip vendor (Wondermedia) using wm
> for example).
> 
>> of_match_table()?  If so, then we should probably fix all codec drivers in
>> one patch.
> 
> Meh, it's fine doing it piecemeal really.  It's hardly urgent anyway.

Ok, thanks for all the explanation. So I'll repost a cleaned up version
of the 2nd patch then. Timur, are you ok with that?


Daniel