Re: [Qemu-devel] [PATCH v5 0/6] file descriptor passing using fd sets

[Corey Bryant <coreyb@linux.vnet.ibm.com>]

On 07/24/2012 08:09 AM, Kevin Wolf wrote:
> Am 23.07.2012 15:07, schrieb Corey Bryant:
>> Corey Bryant (6):
>>    qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg
>>    qapi: Introduce add-fd, remove-fd, query-fdsets
>>    monitor: Clean up fd sets on monitor disconnect
>>    block: Convert open calls to qemu_open
>>    block: Convert close calls to qemu_close
>>    block: Enable qemu_open/close to work with fd sets
>>
>>   block/raw-posix.c |   42 ++++-----
>>   block/raw-win32.c |    6 +-
>>   block/vdi.c       |    5 +-
>>   block/vmdk.c      |   25 +++---
>>   block/vpc.c       |    4 +-
>>   block/vvfat.c     |   16 ++--
>>   cutils.c          |    5 ++
>>   monitor.c         |  244 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>   monitor.h         |    4 +
>>   osdep.c           |  141 +++++++++++++++++++++++++++++++
>>   qapi-schema.json  |   97 +++++++++++++++++++++
>>   qemu-char.c       |   10 ++-
>>   qemu-common.h     |    2 +
>>   qemu-tool.c       |   12 +++
>>   qmp-commands.hx   |  121 ++++++++++++++++++++++++++
>>   savevm.c          |    4 +-
>>   16 files changed, 684 insertions(+), 54 deletions(-)
>
> Apart from the points I commented on in patch 6, and what Eric and you
> found, this looks good to me.
>
> Kevin
>

Great, thanks for the review!

-- 
Regards,
Corey