Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

[Corey Bryant <coreyb@linux.vnet.ibm.com>]

On 07/25/2012 03:25 PM, Eric Blake wrote:
> On 07/25/2012 02:22 AM, Kevin Wolf wrote:
>>>> Hm, not a nice interface where qemu_close() needs the filename and
>>>> (worse) could be given a wrong filename. Maybe it would be better to
>>>> maintain a list of fd -> fdset mappings in qemu_open/close?
>>>>
>>>
>>> I agree, I don't really like it either.
>>>
>>> We already have a list of fd -> fdset mappings (mon_fdset_fd_t ->
>>> mon_fdset_t).  Would it be too costly to loop through all the fdsets/fds
>>> at the beginning of every qemu_close()?
>>
>> I don't think so. qemu_close() is not a fast path and happens almost
>> never, and the list is short enough that searching it isn't a problem
>> anyway.
>
> I agree - just do the loop to do the reverse lookup yourself, rather
> than making qemu_close() have a different signature than close().
>

Great, I'll do this then.

-- 
Regards,
Corey