* [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND
@ 2012-07-24 16:15 Fabio Estevam
2012-07-24 16:15 ` [PATCH 1/2] mtd: nand: Include IMX6 in the list of supported SoCs Fabio Estevam
2012-07-25 5:58 ` [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND Huang Shijie
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2012-07-24 16:15 UTC (permalink / raw)
To: Artem.Bityutskiy; +Cc: Fabio Estevam, linux-mtd, shawn.guo, dwmw2, kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
MTD_NAND_GPMI_NAND driver needs MXS_DMA to be selected, otherwise the following error happens
for imx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mtd/nand/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index b40e172..2062ee9 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM
config MTD_NAND_GPMI_NAND
bool "GPMI NAND Flash Controller driver"
depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
+ select MXS_DMA
help
Enables NAND Flash support for IMX23/28/6.
The GPMI controller is very powerful, with the help of BCH
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/2] mtd: nand: Include IMX6 in the list of supported SoCs
2012-07-24 16:15 [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND Fabio Estevam
@ 2012-07-24 16:15 ` Fabio Estevam
2012-07-25 5:58 ` [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND Huang Shijie
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2012-07-24 16:15 UTC (permalink / raw)
To: Artem.Bityutskiy; +Cc: Fabio Estevam, linux-mtd, shawn.guo, dwmw2, kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Include IMX6 in the list of supported SoCs.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mtd/nand/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index f4e81a7..b40e172 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -464,7 +464,7 @@ config MTD_NAND_GPMI_NAND
bool "GPMI NAND Flash Controller driver"
depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
help
- Enables NAND Flash support for IMX23 or IMX28.
+ Enables NAND Flash support for IMX23, IMX28 or IMX6.
The GPMI controller is very powerful, with the help of BCH
module, it can do the hardware ECC. The GPMI supports several
NAND flashs at the same time. The GPMI may conflicts with other
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND
2012-07-24 16:15 [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND Fabio Estevam
2012-07-24 16:15 ` [PATCH 1/2] mtd: nand: Include IMX6 in the list of supported SoCs Fabio Estevam
@ 2012-07-25 5:58 ` Huang Shijie
2012-07-25 10:32 ` Fabio Estevam
1 sibling, 1 reply; 6+ messages in thread
From: Huang Shijie @ 2012-07-25 5:58 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, Artem.Bityutskiy, linux-mtd, kernel, shawn.guo,
dwmw2
于 2012年07月25日 00:15, Fabio Estevam 写道:
> From: Fabio Estevam<fabio.estevam@freescale.com>
>
> MTD_NAND_GPMI_NAND driver needs MXS_DMA to be selected, otherwise the following error happens
> for imx_v6_v7_defconfig:
>
> drivers/built-in.o: In function `gpmi_dma_filter':
> clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index b40e172..2062ee9 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM
> config MTD_NAND_GPMI_NAND
> bool "GPMI NAND Flash Controller driver"
> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
> + select MXS_DMA
> help
> Enables NAND Flash support for IMX23/28/6.
> The GPMI controller is very powerful, with the help of BCH
thanks, but please see this thread.
http://comments.gmane.org/gmane.linux.ports.arm.kernel/146232
Huang Shijie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND
2012-07-25 5:58 ` [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND Huang Shijie
@ 2012-07-25 10:32 ` Fabio Estevam
2012-07-25 10:38 ` Huang Shijie
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2012-07-25 10:32 UTC (permalink / raw)
To: Huang Shijie
Cc: Fabio Estevam, Artem.Bityutskiy, linux-mtd, kernel, shawn.guo,
dwmw2
On Wed, Jul 25, 2012 at 2:58 AM, Huang Shijie <b32955@freescale.com> wrote:
> thanks, but please see this thread.
>
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/146232
Ok, but what is the conclusion on this then? It has been 8 months
since that thread started and the problem is still present.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND
2012-07-25 10:32 ` Fabio Estevam
@ 2012-07-25 10:38 ` Huang Shijie
2012-07-25 10:38 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Huang Shijie @ 2012-07-25 10:38 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, Artem.Bityutskiy, linux-mtd, kernel, shawn.guo,
dwmw2
于 2012年07月25日 18:32, Fabio Estevam 写道:
> On Wed, Jul 25, 2012 at 2:58 AM, Huang Shijie<b32955@freescale.com> wrote:
>
>> thanks, but please see this thread.
>>
>> http://comments.gmane.org/gmane.linux.ports.arm.kernel/146232
> Ok, but what is the conclusion on this then? It has been 8 months
> since that thread started and the problem is still present.
>
If we want to fix it, we can add the "depend on MXS-DMA" for gpmi nand.
Huang Shijie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND
2012-07-25 10:38 ` Huang Shijie
@ 2012-07-25 10:38 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2012-07-25 10:38 UTC (permalink / raw)
To: Huang Shijie
Cc: Fabio Estevam, Artem.Bityutskiy, linux-mtd, kernel, shawn.guo,
dwmw2
On Wed, Jul 25, 2012 at 7:38 AM, Huang Shijie <b32955@freescale.com> wrote:
> If we want to fix it, we can add the "depend on MXS-DMA" for gpmi nand.
Ok, I will submit a fix using "depends" then.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-25 10:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24 16:15 [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND Fabio Estevam
2012-07-24 16:15 ` [PATCH 1/2] mtd: nand: Include IMX6 in the list of supported SoCs Fabio Estevam
2012-07-25 5:58 ` [PATCH 2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND Huang Shijie
2012-07-25 10:32 ` Fabio Estevam
2012-07-25 10:38 ` Huang Shijie
2012-07-25 10:38 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.