From: Jeff Garzik <jgarzik@pobox.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: JBottomley@parallels.com, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [resend PATCH 5/5] libsas, ipr: cleanup ata_host flags initialization via ata_host_init
Date: Wed, 25 Jul 2012 14:42:54 -0400 [thread overview]
Message-ID: <50103E2E.40300@pobox.com> (raw)
In-Reply-To: <20120710040608.26529.20117.stgit@dwillia2-linux.jf.intel.com>
On 07/10/2012 12:06 AM, Dan Williams wrote:
> libsas and ipr pass flags to ata_host_init that are meant for the port.
>
> ata_host flags:
> ATA_HOST_SIMPLEX = (1 << 0), /* Host is simplex, one DMA channel per host only */
> ATA_HOST_STARTED = (1 << 1), /* Host started */
> ATA_HOST_PARALLEL_SCAN = (1 << 2), /* Ports on this host can be scanned in parallel */
> ATA_HOST_IGNORE_ATA = (1 << 3), /* Ignore ATA devices on this host. */
>
> flags passed by libsas:
> ATA_FLAG_SATA = (1 << 1),
> ATA_FLAG_PIO_DMA = (1 << 7), /* PIO cmds via DMA */
> ATA_FLAG_NCQ = (1 << 10), /* host supports NCQ */
>
> The only one that aliases is ATA_HOST_STARTED which is a 'don't care' in
> the libsas and ipr cases since ata_hosts from these sources are not
> registered with libata.
>
> Cc: Brian King <brking@us.ibm.com>
> Reported-by: Hannes Reinecke <hare@suse.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/ata/libata-core.c | 10 ++--------
> drivers/scsi/ipr.c | 3 +--
> drivers/scsi/libsas/sas_ata.c | 5 +----
> include/linux/libata.h | 3 +--
Acked-by: Jeff Garzik <jgarzik@redhat.com>
next prev parent reply other threads:[~2012-07-25 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 4:05 [resend PATCH 0/5] libsas, libata: suspend / resume and "reset once" Dan Williams
2012-07-10 4:05 ` [resend PATCH 1/5] libata: reset once Dan Williams
2012-07-25 5:20 ` Jeff Garzik
2012-07-10 4:05 ` [resend PATCH 2/5] libata: export ata_port suspend/resume infrastructure for sas Dan Williams
2012-07-25 5:21 ` Jeff Garzik
2012-07-10 4:05 ` [resend PATCH 3/5] libsas: suspend / resume support Dan Williams
2012-07-10 4:06 ` [resend PATCH 4/5] isci: implement suspend/resume support Dan Williams
2012-07-10 4:06 ` [resend PATCH 5/5] libsas, ipr: cleanup ata_host flags initialization via ata_host_init Dan Williams
2012-07-25 18:42 ` Jeff Garzik [this message]
2012-07-25 20:01 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50103E2E.40300@pobox.com \
--to=jgarzik@pobox.com \
--cc=JBottomley@parallels.com \
--cc=dan.j.williams@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.