From: wwang <wei_wang@realsil.com.cn>
To: Aaron Lu <aaron.lu@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Philip Rakity <prakity@marvell.com>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver
Date: Thu, 26 Jul 2012 09:34:19 +0800 [thread overview]
Message-ID: <50109E9B.6080806@realsil.com.cn> (raw)
In-Reply-To: <20120725101601.GA8578@aarontestpc.amd.com>
Hi Aaron:
Thank you. I will modify our host per your suggestion.
BR,
wwang
于 2012年07月25日 18:16, Aaron Lu 写道:
> Hi Wei,
>
> We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would
> sugget you do something like this:
>
> static void realtek_init(struct realtek_sdmmc *host)
> {
> struct mmc_host *mmc = host->mmc;
> ... ...
> /*
> * since you have set MMC_CAP_MAX_CURRENT_800 in your
> * original code, I assume your host can provide more than
> * 800mA, and you've set the 1.8v support bit in your original
> * code for the host, so I also set the max_current_180 to 800mA.
> */
> mmc->max_current_330 = 800;
> mmc->max_current_180 = 800;
> ... ...
> }
>
> Does this look right to you?
>
> Thanks,
> Aaron
>
>
next prev parent reply other threads:[~2012-07-26 1:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 9:42 [PATCH 1/3] drivers/misc: Add realtek card reader core driver wei_wang
2012-07-23 11:17 ` Dan Carpenter
2012-07-26 3:11 ` wwang
2012-07-26 3:59 ` gregkh
2012-07-23 11:24 ` [PATCH 1/3] drivers/misc: Add " Borislav Petkov
2012-07-23 15:14 ` Matthew Garrett
2012-07-23 16:33 ` Borislav Petkov
2012-07-24 1:21 ` wwang
2012-07-24 6:44 ` Borislav Petkov
2012-07-24 8:47 ` wwang
2012-07-24 14:07 ` Borislav Petkov
[not found] ` <500F59D7.2050508@realsil.com.cn>
2012-07-25 8:04 ` Borislav Petkov
2012-07-25 10:16 ` Aaron Lu
2012-07-26 1:34 ` wwang [this message]
2012-07-26 8:43 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2012-07-31 7:42 wei_wang
2012-07-31 7:42 ` wei_wang
2012-07-31 11:23 ` Arnd Bergmann
2012-08-01 6:19 ` wwang
2012-08-01 14:31 ` Arnd Bergmann
2012-08-03 2:31 ` wwang
2012-08-03 14:39 ` Arnd Bergmann
2012-08-13 20:59 ` Maxim Levitsky
2012-07-25 3:02 wei_wang
2012-07-20 10:09 wei_wang
2012-07-19 9:54 wei_wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50109E9B.6080806@realsil.com.cn \
--to=wei_wang@realsil.com.cn \
--cc=aaron.lu@amd.com \
--cc=bp@alien8.de \
--cc=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.