From: Daniel Mack <zonque@gmail.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: AnilKumar Ch <anilkumar@ti.com>,
tony@atomide.com, devicetree-discuss@lists.ozlabs.org,
grant.likely@secretlab.ca, mkl@pengutronix.de,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
wg@grandegger.com
Subject: Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data
Date: Thu, 26 Jul 2012 10:36:55 +0200 [thread overview]
Message-ID: <501101A7.2030503@gmail.com> (raw)
In-Reply-To: <500FE9FC.7070303@mvista.com>
On 25.07.2012 14:43, Sergei Shtylyov wrote:
> Hello.
>
> On 25-07-2012 16:23, AnilKumar Ch wrote:
>
>> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
>> by adding d_can device node with all the necessary parameters.
>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> ---
>> arch/arm/boot/dts/am33xx.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 9b974dc..2db2ffb 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -163,5 +163,10 @@
>> #size-cells = <0>;
>> ti,hwmods = "i2c3";
>> };
>> +
>> + dcan1: d_can@481D0000 {
>
> Address postfix in the node name and no "reg" property?
This still works due to the hwmod mappings OMAP relies on. I would still
put it there, so the switch to real DT definitions will be less painful.
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data
Date: Thu, 26 Jul 2012 10:36:55 +0200 [thread overview]
Message-ID: <501101A7.2030503@gmail.com> (raw)
In-Reply-To: <500FE9FC.7070303@mvista.com>
On 25.07.2012 14:43, Sergei Shtylyov wrote:
> Hello.
>
> On 25-07-2012 16:23, AnilKumar Ch wrote:
>
>> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
>> by adding d_can device node with all the necessary parameters.
>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> ---
>> arch/arm/boot/dts/am33xx.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 9b974dc..2db2ffb 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -163,5 +163,10 @@
>> #size-cells = <0>;
>> ti,hwmods = "i2c3";
>> };
>> +
>> + dcan1: d_can at 481D0000 {
>
> Address postfix in the node name and no "reg" property?
This still works due to the hwmod mappings OMAP relies on. I would still
put it there, so the switch to real DT definitions will be less painful.
Daniel
next prev parent reply other threads:[~2012-07-26 8:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 12:23 [PATCH v2 0/2] Add D_CAN device tree data to AM335x-EVM AnilKumar Ch
2012-07-25 12:23 ` AnilKumar Ch
2012-07-25 12:23 ` [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data AnilKumar Ch
2012-07-25 12:23 ` AnilKumar Ch
2012-07-25 12:43 ` Sergei Shtylyov
2012-07-25 12:43 ` Sergei Shtylyov
2012-07-26 8:36 ` Daniel Mack [this message]
2012-07-26 8:36 ` Daniel Mack
2012-07-26 13:04 ` Sergei Shtylyov
2012-07-26 13:04 ` Sergei Shtylyov
[not found] ` <50114069.7070605-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-08-03 9:14 ` Vaibhav Hiremath
2012-08-03 9:14 ` Vaibhav Hiremath
2012-07-26 8:46 ` Koen Kooi
2012-07-26 8:46 ` Koen Kooi
[not found] ` <9D2B44C8-820E-4E96-A480-7A650583BC92-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>
2012-07-26 9:03 ` AnilKumar, Chimata
2012-07-26 9:03 ` AnilKumar, Chimata
[not found] ` <331ABD5ECB02734CA317220B2BBEABC13EA04433-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-07-26 9:14 ` Marc Kleine-Budde
2012-07-26 9:14 ` Marc Kleine-Budde
2012-07-26 9:35 ` Koen Kooi
2012-07-26 9:35 ` Koen Kooi
2012-08-03 6:28 ` Vaibhav Hiremath
2012-08-03 6:28 ` Vaibhav Hiremath
2012-08-07 11:40 ` AnilKumar, Chimata
2012-08-07 11:40 ` AnilKumar, Chimata
[not found] ` <1343219012-19472-1-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-07-25 12:23 ` [PATCH v2 2/2] arm/dts: AM33XX: Configure pinmuxs for D_CAN1 on AM335x-EVM AnilKumar Ch
2012-07-25 12:23 ` AnilKumar Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501101A7.2030503@gmail.com \
--to=zonque@gmail.com \
--cc=anilkumar@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=sshtylyov@mvista.com \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.