From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: fix PCIe resource calculation
Date: Thu, 26 Jul 2012 07:57:51 -0500 [thread overview]
Message-ID: <50113ECF.10209@gmail.com> (raw)
In-Reply-To: <1343239358-3239-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 07/25/2012 01:02 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Commit 0acc43c "ARM: tegra: use fixed PCI i/o mapping" re-numbered the
> resource array entries that the driver used, but missed one location. This
> causes request_resource() to fail, and the driver to panic.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Rob, I'm not sure if you can squash this into your PCIE commit, or if
> we need to apply it on top?
I'm rebasing the branch and will incorporate it. Thanks for testing.
Rob
>
> arch/arm/mach-tegra/pcie.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c
> index 576347a..3463fb5 100644
> --- a/arch/arm/mach-tegra/pcie.c
> +++ b/arch/arm/mach-tegra/pcie.c
> @@ -406,7 +406,7 @@ static int tegra_pcie_setup(int nr, struct pci_sys_data *sys)
> pp->res[1].name = pp->prefetch_space_name;
> if (pp->index == 0) {
> pp->res[1].start = PREFETCH_MEM_BASE_0;
> - pp->res[1].end = pp->res[2].start + PREFETCH_MEM_SIZE_0 - 1;
> + pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_0 - 1;
> } else {
> pp->res[1].start = PREFETCH_MEM_BASE_1;
> pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_1 - 1;
>
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: fix PCIe resource calculation
Date: Thu, 26 Jul 2012 07:57:51 -0500 [thread overview]
Message-ID: <50113ECF.10209@gmail.com> (raw)
In-Reply-To: <1343239358-3239-1-git-send-email-swarren@wwwdotorg.org>
On 07/25/2012 01:02 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Commit 0acc43c "ARM: tegra: use fixed PCI i/o mapping" re-numbered the
> resource array entries that the driver used, but missed one location. This
> causes request_resource() to fail, and the driver to panic.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Rob, I'm not sure if you can squash this into your PCIE commit, or if
> we need to apply it on top?
I'm rebasing the branch and will incorporate it. Thanks for testing.
Rob
>
> arch/arm/mach-tegra/pcie.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c
> index 576347a..3463fb5 100644
> --- a/arch/arm/mach-tegra/pcie.c
> +++ b/arch/arm/mach-tegra/pcie.c
> @@ -406,7 +406,7 @@ static int tegra_pcie_setup(int nr, struct pci_sys_data *sys)
> pp->res[1].name = pp->prefetch_space_name;
> if (pp->index == 0) {
> pp->res[1].start = PREFETCH_MEM_BASE_0;
> - pp->res[1].end = pp->res[2].start + PREFETCH_MEM_SIZE_0 - 1;
> + pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_0 - 1;
> } else {
> pp->res[1].start = PREFETCH_MEM_BASE_1;
> pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_1 - 1;
>
next prev parent reply other threads:[~2012-07-26 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 18:02 [PATCH] ARM: tegra: fix PCIe resource calculation Stephen Warren
2012-07-25 18:02 ` Stephen Warren
[not found] ` <1343239358-3239-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-07-26 12:57 ` Rob Herring [this message]
2012-07-26 12:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50113ECF.10209@gmail.com \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.